Ease use of local charts#434
Open
c0d1ngm0nk3y wants to merge 1 commit into
Open
Conversation
| --env INSTALL_OPTIONAL_COMPONENTS \ | ||
| -v "$$PWD/temp/certs:/certs" -v "$$PWD/temp/kubeconfig:/helm/.kube/config:ro" -v "$$PWD:/wd" --workdir /wd ghcr.io/helmfile/helmfile:v$(HELMFILE_VERSION) helmfile sync | ||
|
|
||
| @if ! command -v helmfil &> /dev/null; then \ |
Member
There was a problem hiding this comment.
Suggested change
| @if ! command -v helmfil &> /dev/null; then \ | |
| @if ! command -v helmfile &> /dev/null; then \ |
Comment on lines
+15
to
+18
| echo "helmfile not found, using docker to run helmfile"; \ | ||
| docker run --rm --net=host --env-file temp/secrets.env \ | ||
| --env INSTALL_OPTIONAL_COMPONENTS \ | ||
| -v "$$PWD/temp/certs:/certs" -v "$$PWD/temp/kubeconfig:/helm/.kube/config:ro" -v "$$PWD:/wd" --workdir /wd ghcr.io/helmfile/helmfile:v$(HELMFILE_VERSION) helmfile sync; \ |
Member
There was a problem hiding this comment.
I don't quite like this solution, the docker container was introduced to reduce complexity but this solution requires more and complicated configuration (mount helm directory manually, set path to chart in versions.yaml to mounted path instead of filesystem path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.