Migrate file upload digest algorithm from MD5 to SHA-384 (FIPS 140-3 + NCS) - #1884
Open
vkalapov wants to merge 1 commit into
Open
Migrate file upload digest algorithm from MD5 to SHA-384 (FIPS 140-3 + NCS)#1884vkalapov wants to merge 1 commit into
vkalapov wants to merge 1 commit into
Conversation
…+ NCS) LMCROSSITXSADEPLOY-3224
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change
Constants.DIGEST_ALGORITHMfrom"MD5"to"SHA-384"and update all test fixtures accordingly.Why
SHA-384 satisfies both FIPS 140-3 (FIPS 180-4) and NCS MODERATE requirements. MD5 and SHA-256 are not approved at NCS MODERATE level.
Compatibility
Backward compatible — no breaking change.
The server always computes and stores its own digest on upload (
DatabaseFileService→SqlFileQueryProvider). No client-sent digest is ever read or verified on the server side.isFileAlreadyUploadedwill hit"Unsupported digest algorithm"for the SHA-384 entries returned byGET /files, re-upload on every retry instead of skipping — deploys complete successfully.UploadAppStepdetects mismatch between freshly computed SHA-384 and the MD5 value stored in the CF app environment → one-time forced re-upload of every app binary. Self-heals on the second deploy.LMCROSSITXSADEPLOY-3224