feat: add public share link functionality and improve error handling#81
Open
kplgr wants to merge 1 commit intocloudlena:mainfrom
Open
feat: add public share link functionality and improve error handling#81kplgr wants to merge 1 commit intocloudlena:mainfrom
kplgr wants to merge 1 commit intocloudlena:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my use case, I needed a way to generate permalinks to files. If anybody finds this useful, feel free to merge.
I have added a file menu option with some warnings so users understand what they're doing, as well as a simple test of permalink access for the user to know whether the bucket is configured for this or not. Some tests as well.
I also fixed some missing JS quotes in the template, and it got swept in the same commit.