Skip to content

feat: add use_fullname input to control IAM role name generation#45

Open
nitrocode with Copilot wants to merge 3 commits into
mainfrom
copilot/add-use-fullname-for-iam-role
Open

feat: add use_fullname input to control IAM role name generation#45
nitrocode with Copilot wants to merge 3 commits into
mainfrom
copilot/add-use-fullname-for-iam-role

Conversation

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown

The IAM role name was always derived from the full label context ID (e.g. acme-core-gbl-auto-gha-iam), with no escape hatch to use a short, explicit name.

Changes

  • src/variables.tf — Adds use_fullname (bool, default true) mirroring the same input from cloudposse/terraform-aws-iam-role and following the same convention as bucket_name in cloudposse/terraform-aws-s3-bucket. Default true preserves existing behavior.

  • src/main.tf — Role name now conditionally uses module.this.id or module.this.name:

    name = var.use_fullname ? module.this.id : module.this.name
  • README.yaml — Adds example and rationale for using use_fullname: false to create a role by short name:

    vars:
      name: GitHubActionsRole
      use_fullname: false

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@mergify mergify Bot requested review from a team March 6, 2026 01:40
@mergify

mergify Bot commented Mar 6, 2026

Copy link
Copy Markdown

Important

Title is necessary and should not be empty.

Kindly provide a meaningful title for this Pull Request.

@mergify mergify Bot added triage Needs triage wip Work in Progress: Not ready for final review or merge labels Mar 6, 2026
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Copilot AI changed the title [WIP] Add use_fullname to IAM role resource with naming consistency feat: add use_fullname input to control IAM role name generation Mar 6, 2026
@mergify mergify Bot added needs-test Needs testing and removed wip Work in Progress: Not ready for final review or merge labels Mar 6, 2026
@nitrocode nitrocode marked this pull request as ready for review March 6, 2026 01:43
@nitrocode nitrocode enabled auto-merge March 6, 2026 01:51
@nitrocode

Copy link
Copy Markdown

/terratest

@mergify mergify Bot requested a review from a team March 6, 2026 01:52
@mergify mergify Bot removed the triage Needs triage label Mar 6, 2026
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

There are no real tests for this component. So we set terratest statuses to successful execution without running any tests

@mergify

mergify Bot commented Mar 6, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Apr 5, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Apr 5, 2026
@mergify

mergify Bot commented Apr 5, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Apr 12, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Apr 12, 2026
@mergify

mergify Bot commented Apr 12, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify Bot removed the stale This PR has gone stale label May 26, 2026
@mergify

mergify Bot commented May 26, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jun 2, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jun 2, 2026
@mergify

mergify Bot commented Jun 2, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jun 9, 2026
@mergify

mergify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jun 16, 2026
@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jun 23, 2026
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jun 30, 2026
@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jul 7, 2026
@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify Bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jul 14, 2026
@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Thanks @Copilot for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-test Needs testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants