chore: switch to @tony.ganchev/eslint-plugin-header#40
Closed
NathanZlion wants to merge 1 commit intomainfrom
Closed
chore: switch to @tony.ganchev/eslint-plugin-header#40NathanZlion wants to merge 1 commit intomainfrom
NathanZlion wants to merge 1 commit intomainfrom
Conversation
Hi, team, I noticed you are using _eslint-plugin-header_ on ESLint 8. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/documenter#112 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
NathanZlion
requested review from
a team,
amanabiy and
srungta08
and removed request for
a team,
amanabiy and
srungta08
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.