feat: Add bubble series to cartesian chart component#191
Open
avinashbot wants to merge 11 commits intomainfrom
Open
feat: Add bubble series to cartesian chart component#191avinashbot wants to merge 11 commits intomainfrom
avinashbot wants to merge 11 commits intomainfrom
Conversation
avinashbot
commented
Mar 24, 2026
cansuaa
previously approved these changes
Mar 24, 2026
pan-kot
reviewed
Mar 24, 2026
pan-kot
reviewed
Mar 25, 2026
pan-kot
reviewed
Mar 25, 2026
pan-kot
reviewed
Mar 25, 2026
cc4bc2e to
7e0a3d7
Compare
a969c12 to
195fdac
Compare
Member
|
@georgylobko, let's change |
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
pan-kot
reviewed
Mar 27, 2026
* chore: Z axis for the bubble chart * chore: small fix * chore: Upd types and snapshots * chore: Additional tests * chore: Refactoring * refactor: Changes z-axis to bubble-axis (#195) * poc * z -> size * fix: tests * small fix * chore: Update snapshots * chore: Update snapshots * chore: Update snapshots --------- Co-authored-by: Georgii Lobko <globko@amazon.de> --------- Co-authored-by: Andrei Zhaleznichenka <zhalea@amazon.de>
34e3de3 to
b28b234
Compare
pan-kot
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new "bubble" type for chart series, which accepts a
zvalue in addition toxandy.Related links, issue #, if available: AWSUI-61535
How has this been tested?
Modified existing unit tests that cover all series types to include bubble series. There's also a new dev page for the bubble chart, which (if I understand it correctly) is now screenshot-tested.
Also reviewed it with our accessibility specialists and visual designers. And of course, manually on some local browsers with VoiceOver.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.