[WIP]appendMw: use minimal numeric suffix for unique names#1405
Open
srpvpn wants to merge 3 commits intocloudwego:developfrom
Open
[WIP]appendMw: use minimal numeric suffix for unique names#1405srpvpn wants to merge 3 commits intocloudwego:developfrom
srpvpn wants to merge 3 commits intocloudwego:developfrom
Conversation
|
感谢。能否补充下对应问题的复现场景并且补充单测~ |
Author
|
@HeyJavaBean 问题复现场景 原来的 例如,当存在 ["mw"] 时:
这生成了无意义的名称如 "mw01", "mw012" 而不是正确的 "mw0", "mw1", "mw2"。 修复方案:
单元测试: |
Author
|
Hi @HeyJavaBean , gentle reminder about this PR. I've addressed the feedback on tests and reproduction. Is there anything else needed? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
fix(appendMw): generate sequential middleware names(Optional) Translate the PR title into Chinese.
修复(appendMw): 顺序生成中间件唯一名称