docs(hz): add README, clarifying comments, and fix broken tests#1492
Merged
docs(hz): add README, clarifying comments, and fix broken tests#1492
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
+ Coverage 86.32% 86.36% +0.03%
==========================================
Files 148 148
Lines 14169 14169
==========================================
+ Hits 12232 12237 +5
+ Misses 1410 1407 -3
+ Partials 527 525 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0e00f41 to
90ff7b4
Compare
Add a comprehensive README.md documenting hz's architecture, dual-mode execution model, code generation pipeline, and template system. Add comments to unclear code across 17 source files in cmd/hz/ covering the model type system, router tree construction, template generation, handler/client codegen, argument serialization, and plugin architecture. Fix two pre-existing test failures: - generator/model_test: add missing GoType field to Enum test data - thrift/plugin_test: generate fixture programmatically instead of depending on a never-committed binary file (request_thrift.out)
90ff7b4 to
542f4f3
Compare
DMwangnima
approved these changes
Apr 9, 2026
YangruiEmma
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a comprehensive README.md documenting hz's architecture, dual-mode execution model, code generation pipeline, and template system.
Add comments to unclear code across 17 source files in cmd/hz/ covering the model type system, router tree construction, template generation, handler/client codegen, argument serialization, and plugin architecture.
Fix two pre-existing test failures: