Skip to content

feat: use hashbrown instead of ahash#222

Open
utkarshgupta137 wants to merge 1 commit intocloudwego:mainfrom
utkarshgupta137:feat/hashbrown
Open

feat: use hashbrown instead of ahash#222
utkarshgupta137 wants to merge 1 commit intocloudwego:mainfrom
utkarshgupta137:feat/hashbrown

Conversation

@utkarshgupta137
Copy link
Copy Markdown
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) More detailed description for this PR(en: English/zh: Chinese).

Switch from ahash to hashbrown. These has 2 benefits:

  • ahash uses std::collections::HashMap which is also based on hashbrown, but the hashbrown crate itself usually has a newer version of the hash table & uses more aggressive inline by default
  • hashbrown uses foldhash as the default hasher, which has shown to be slightly better or equal to ahash & foldhash has better support on a wider range of platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant