lchroot: allow to be run without tty#2
Open
guusbertens wants to merge 1 commit into
Open
Conversation
lchroot uses bash's `set -e`, which does not allow commands to fail. lchroot then uses `tty` to get the TTY name mostly for informational purposes. However, `tty` fails if there is no tty, for instance when running from cron. Allow `tty` to fail.
Author
|
@aphmschonewille Would you be interested in taking this PR? And for the future, how should I get PRs to your attention? |
Author
|
@sumit42876 @aphmschonewille Have you had time to look at my previous comment? I'm looking forward to hearing from you. |
Member
|
Hi Guus, For stupid reasons i've missed your PR. Let me have a look at it -Antoine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lchroot uses bash's
set -e, which does not allow commands to fail. lchroot then usesttyto get the TTY name mostly for informational purposes. However,ttyfails if there is no tty, for instance when running from cron. Allowttyto fail.