Fix worker metrics panic caused by inconsistent Prometheus label cardinality#185
Open
pablo1664 wants to merge 3 commits intoclyso:mainfrom
Open
Fix worker metrics panic caused by inconsistent Prometheus label cardinality#185pablo1664 wants to merge 3 commits intoclyso:mainfrom
pablo1664 wants to merge 3 commits intoclyso:mainfrom
Conversation
fa30c78 to
30642f3
Compare
Signed-off-by: François PIRES <francois@pires.eus>
30642f3 to
4abc168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR fixes a worker panic when metrics are enabled.
Problem
copy_in_progress_obj_bytesis aGaugeVecdefined with 3 labels (flow,user,bucket), but the worker was conditionally building labels and sometimes sending only 2 (for example missinguser).This caused:
panic: inconsistent label cardinality: expected 3 label values but got 2Fix
WorkerInProgressBytesInc()WorkerInProgressBytesDec()Changed file:
Validation
go test ./pkg/metrics ./service/worker/copy ./service/worker/handler(exit code 0)