Skip to content

Routing Policies Management#187

Open
s0nea wants to merge 21 commits intoclyso:mainfrom
s0nea:wip-routing-policies
Open

Routing Policies Management#187
s0nea wants to merge 21 commits intoclyso:mainfrom
s0nea:wip-routing-policies

Conversation

@s0nea
Copy link
Contributor

@s0nea s0nea commented Mar 13, 2026

Pull Request

Description

Related Issue

Link to the GitHub issue (if applicable): #[issue number]

Checklist

Note: By submitting this PR, you agree to license your contributions under the Apache 2.0 License and follow our Code of Conduct.

@s0nea s0nea requested a review from mzymta March 13, 2026 19:14
@s0nea s0nea force-pushed the wip-routing-policies branch 2 times, most recently from 9823081 to 3b7b712 Compare March 13, 2026 20:06
@s0nea s0nea marked this pull request as ready for review March 13, 2026 20:08
@s0nea s0nea force-pushed the wip-routing-policies branch 5 times, most recently from 17571f8 to 9b001ce Compare March 17, 2026 14:07
mzymta
mzymta reviewed Mar 19, 2026
View reviewed changes
@s0nea s0nea force-pushed the wip-routing-policies branch from 9b001ce to 632e3bf Compare March 20, 2026 12:48
@s0nea
Copy link
Contributor Author

s0nea commented Mar 20, 2026

Thank you for your review @mzymta 🙂

I addressed all your comments and/or added replies. Could you please take another look? Thank you!

@s0nea s0nea requested a review from mzymta March 20, 2026 12:50
@s0nea
chore: make commit lint accept on-behalf-of
48ce967 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea s0nea force-pushed the wip-routing-policies branch from 632e3bf to bf41456 Compare March 20, 2026 12:51
s0nea added 8 commits March 23, 2026 16:48
@s0nea
refactor(ui): add storage tag component
28c7756 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
refactor(ui): add chorus notification composable
2172067 
Move the notificiation creation and removal into a composable for
easier re-use.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
refactor(ui): add ChorusUserCardList
5476fe4 
Create a separate component for the list of user cards. So that it can
be used for the creation of replications as well as routing policies.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): fix issue when no replications exist
3e1d7fb 
If no replications exist at all, the map function will throw an error
because res.replications is undefined.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): define storage provider default value
0e02d9d 
The default storage provider (0 -> S3) may not be retuned by the API.
We'll have to set a default value to deal with the situation. Otherwise
the value will stay undefined.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): fix typo in css class definition
77a364e 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): add replication breadcrumb translations
50c0011 
Add missing translations for the add replication page.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): use CDashboardPage instead of simple div
fa595c8 
Use the CDashboardPage instead of the div in order to apply the correct
styling without additional css classes.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea s0nea force-pushed the wip-routing-policies branch from bf41456 to 2e52a02 Compare March 24, 2026 16:33
@s0nea
Copy link
Contributor Author

s0nea commented Mar 25, 2026

Hey @mzymta,

I addressed your comments and created two additional issue we talked about:

How do we want to continue?

@s0nea s0nea force-pushed the wip-routing-policies branch from 2e52a02 to b025c69 Compare March 25, 2026 12:47
mzymta
mzymta reviewed Mar 25, 2026
View reviewed changes
ui/src/components/chorus/common/ChorusStorageCard/ChorusStorageCard.vue Outdated
Comment on lines +77 to +84
if (!!props.to || !props.isSelectable || props.isDisabled) {
return;
}

if (props.isSelected) {
if (props.isDeselectable) {
emit('deselect');
}
Copy link
Collaborator

@mzymta mzymta Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many ifs, looks a bit confusing. Also lets not use !!
How about?

function handleClick() {
    if (props.to || !props.isSelectable || props.isDisabled) {
      return;
    }

    if (!props.isSelected) {
      emit('select');

      return;
    } 

    if (props.isDeselectable) {
      emit('deselect');
    }
  }

ui/src/components/chorus/routing-policies/RoutingPolicyBucketCell/RoutingPolicyBucketCell.vue Outdated
routingPolicy: RoutingPolicy;
}>();

const disableTooltip = props.routingPolicy.bucket !== '*';
Copy link
Collaborator

@mzymta mzymta Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are working with reactive states on the ui and even if we know that something won't change, it still could technically change (e.g. the store updates rows with splice when you block/unblock, so the prop can change. Without computed() it won't update).
So we should always deal with reactive values on the ui

@s0nea s0nea force-pushed the wip-routing-policies branch from b025c69 to d2fd678 Compare March 25, 2026 15:35
@s0nea
Copy link
Contributor Author

s0nea commented Mar 25, 2026

Thank you for the second review @mzymta . I updated the PR accordingly.

@s0nea s0nea requested a review from mzymta March 25, 2026 15:38
mzymta
mzymta reviewed Mar 25, 2026
View reviewed changes
ui/src/components/chorus/common/ChorusStorageCard/ChorusStorageCard.vue Outdated
}

emit('select');
if (props.isSelected) {
Copy link
Collaborator

@mzymta mzymta Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be if (!props.isSelected) {

mzymta
mzymta reviewed Mar 25, 2026
View reviewed changes
...components/chorus/routing-policies/RoutingPoliciesListActions/RoutingPoliciesListActions.vue Outdated
type="primary"
size="medium"
ghost
class="add-replication-button"
Copy link
Collaborator

@mzymta mzymta Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add-routing-policy-button

s0nea added 12 commits March 25, 2026 17:35
@s0nea
feat(ui): add routing policies overview table
f9c9cd9 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add routing policies filter
82b7d52 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add routing policies delete action
611d483 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add routing policy add page
fca00ca 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add user selection
18bc73d 
Add the user selection to the routing policy creation form.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add bucket selection
7afcb78 
Add the bucket selection to the routing policy creation form.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add deselect option to storage card
046757b 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add storage selection
2762f53 
Add the storage selection to the routing policy creation form.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add status selection
c3feb5d 
Add the status selection to the routing policy creation form.

Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
feat(ui): add routing policy summary dialog
813e4a2 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): add button CSS class
fe63adf 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea
fix(ui): fix condition for card selection event
5a94c03 
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP t.dehler@sap.com
@s0nea s0nea force-pushed the wip-routing-policies branch from d2fd678 to 5a94c03 Compare March 25, 2026 16:53
@s0nea s0nea requested a review from mzymta March 25, 2026 17:03
@s0nea s0nea mentioned this pull request Mar 25, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schucly schucly Awaiting requested review from schucly schucly is a code owner

@arttor arttor Awaiting requested review from arttor arttor is a code owner

@fa-at-pulsit fa-at-pulsit Awaiting requested review from fa-at-pulsit fa-at-pulsit is a code owner

@aiivashchenko aiivashchenko Awaiting requested review from aiivashchenko aiivashchenko is a code owner

@mzymta mzymta Awaiting requested review from mzymta

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s0nea @mzymta