This repository was archived by the owner on May 12, 2023. It is now read-only.
Include state in auth url#17
Open
peterchaula wants to merge 2 commits intocmcdonaldca:masterfrom
peterchaula:new_oauth_update
Open
Include state in auth url#17peterchaula wants to merge 2 commits intocmcdonaldca:masterfrom peterchaula:new_oauth_update
peterchaula wants to merge 2 commits intocmcdonaldca:masterfrom
peterchaula:new_oauth_update
Conversation
It seems like if you follow Shopify OAuth Documentation and include the **state** parameter for verification the **hmac** verification fails on the client server size. My assumption is that Shopify includes **state** in calculation of the hash
>https://{shop}.myshopify.com/admin/oauth/authorize?client_id={api_key}&scope={scopes}&redirect_uri={redirect_uri}&state={nonce}
>{nonce} - a randomly selected value provided by your application, which is unique for each authorization request. During the OAuth >callback phase, your application must check that this value matches the one you provided during authorization. This mechanism is >important for the security of your application.
[Shopify docs](https://help.shopify.com/api/guides/authentication/oauth#scopes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like if you follow Shopify OAuth Documentation and include the state parameter for verification the hmac verification fails on the client server size. My assumption is that Shopify includes state in calculation of the hash
Shopify docs