Skip to content

fix(mipro): store demos_idx instead of instruction_idx in raw_chosen_params#10

Open
isaacbmiller wants to merge 1 commit intomainfrom
fix/mipro-raw-chosen-params
Open

fix(mipro): store demos_idx instead of instruction_idx in raw_chosen_params#10
isaacbmiller wants to merge 1 commit intomainfrom
fix/mipro-raw-chosen-params

Conversation

@isaacbmiller
Copy link
Copy Markdown

The raw_chosen_params dict incorrectly stores instruction_idx for the
{i}_predictor_demos key instead of demos_idx. This is a copy-paste error

  • the line immediately above correctly stores demos_idx in trial_logs.

This causes Optuna's Bayesian model to learn wrong associations between demo
choices and scores during minibatch optimization, silently degrading
optimization quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant