fix(mipro): store demos_idx instead of instruction_idx in raw_chosen_params#10
Open
isaacbmiller wants to merge 1 commit intomainfrom
Open
fix(mipro): store demos_idx instead of instruction_idx in raw_chosen_params#10isaacbmiller wants to merge 1 commit intomainfrom
isaacbmiller wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
raw_chosen_paramsdict incorrectly storesinstruction_idxfor the{i}_predictor_demoskey instead ofdemos_idx. This is a copy-paste errordemos_idxintrial_logs.This causes Optuna's Bayesian model to learn wrong associations between demo
choices and scores during minibatch optimization, silently degrading
optimization quality.