fix(finetune): fix variable shadowing that broke per-predictor trace filtering#11
Open
isaacbmiller wants to merge 1 commit intomainfrom
Open
fix(finetune): fix variable shadowing that broke per-predictor trace filtering#11isaacbmiller wants to merge 1 commit intomainfrom
isaacbmiller wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop variable
pred_indin_prepare_finetune_datashadows the functionparameter of the same name. This causes the filter condition
pred_ind == pred_indto always evaluate toTrue(self-comparison),meaning all predictor traces are included regardless of the
pred_indparameter.
When
multitask=False, each predictor should only receive its own tracesfor fine-tuning, but due to this shadowing bug, every predictor receives
all traces — effectively behaving the same as
multitask=True.Fix: rename the loop variable to
trace_indto avoid shadowing.