fix(predict): handle temperature=0 correctly instead of treating it as unset#12
Open
isaacbmiller wants to merge 1 commit intomainfrom
Open
fix(predict): handle temperature=0 correctly instead of treating it as unset#12isaacbmiller wants to merge 1 commit intomainfrom
isaacbmiller wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temperature=0is a valid and common setting for deterministic generation,but the
oroperator treats0as falsy. This causes the user's explicittemperature=0to be silently dropped and replaced with the LM's default.When
num_generations > 1, this leads to the temperature being overriddento
0.7, giving random outputs when the user explicitly requesteddeterministic generation.
Fix: use explicit
Nonecheck instead ofor.