Skip to content

cms-common: cmsset_default fixes for bash#10419

Merged
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/masterfrom
cms-common-bash-fix
Mar 15, 2026
Merged

cms-common: cmsset_default fixes for bash#10419
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/masterfrom
cms-common-bash-fix

Conversation

@smuzaffar
Copy link
Contributor

Fixes cms-sw/cmssw#50399

This includes cms-sw/cms-common@743df23 change to avoid setting cms env under strict bash e.g. when run under set -u

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2026

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cms-bot#2706

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26c2a9/51964/summary.html
COMMIT: 728df9d
CMSSW: CMSSW_16_1_X_2026-03-14-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10419/51964/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4185208
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4185182
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit db3597c into IB/CMSSW_16_1_X/master Mar 15, 2026
8 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error due to sintax in /cvmfs/cms.cern.ch/cmsset_default.sh

2 participants