Skip to content

fix(chat): render blocked reason after prose#320

Merged
cniska merged 2 commits into
mainfrom
blocked-reason-render
Jul 16, 2026
Merged

fix(chat): render blocked reason after prose#320
cniska merged 2 commits into
mainfrom
blocked-reason-render

Conversation

@cniska

@cniska cniska commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Motivation

A signal_blocked turn delivers its reason via the signal argument, not as streamed prose. The client rendered the reason as a fallback bubble only when no prose had streamed — so any narration suppressed it, and a correct block showed as an empty-looking turn (tool rows + "Worked", nothing else).

Summary

  • carry outputStreamed on the reply so the client knows whether output already reached the screen as deltas
  • gate the fallback bubble on outputStreamed, replacing the "any prose streamed" row-count proxy that misread narration as the answer
  • mark host-synthesized notices (yield / stopped-on-errors) as not-streamed so they still render
  • enable debug logging in bun run dogfood so the client log is captured while dogfooding

@cniska cniska changed the title fix(chat): render blocked reason when prose streamed fix(chat): render blocked reason after prose Jul 16, 2026
@cniska
cniska force-pushed the blocked-reason-render branch from ff6ed70 to 8f37a4a Compare July 16, 2026 15:52
@cniska
cniska merged commit c89e06e into main Jul 16, 2026
4 checks passed
@cniska
cniska deleted the blocked-reason-render branch July 16, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant