Skip to content

Add attr to wide view of failover reservations #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umswmayj merged 3 commits into from
Mar 25, 2026
Merged

Add attr to wide view of failover reservations #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
022fba6
wide view of failover reservations
umswmayj Mar 25, 2026
1866bbf
adding columns for cr reservations
mblos Mar 25, 2026
7463487
fix allocations
mblos Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions api/v1alpha1/reservation_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,16 @@ type ReservationStatus struct {
// +kubebuilder:printcolumn:name="Type",type="string",JSONPath=".metadata.labels['reservations\\.cortex\\.cloud/type']"
// +kubebuilder:printcolumn:name="Host",type="string",JSONPath=".status.host"
// +kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status"
// +kubebuilder:printcolumn:name="ResourceGroup",type="string",JSONPath=".spec.committedResourceReservation.resourceGroup"
// +kubebuilder:printcolumn:name="Project",type="string",JSONPath=".spec.committedResourceReservation.projectID"
// +kubebuilder:printcolumn:name="AZ",type="string",JSONPath=".spec.availabilityZone"
// +kubebuilder:printcolumn:name="StartTime",type="string",JSONPath=".spec.startTime",priority=1
// +kubebuilder:printcolumn:name="EndTime",type="string",JSONPath=".spec.endTime"
// +kubebuilder:printcolumn:name="Resources",type="string",JSONPath=".spec.resources",priority=1
// +kubebuilder:printcolumn:name="LastChanged",type="date",JSONPath=".status.failoverReservation.lastChanged",priority=1
// +kubebuilder:printcolumn:name="AcknowledgedAt",type="date",JSONPath=".status.failoverReservation.acknowledgedAt",priority=1
// +kubebuilder:printcolumn:name="CR Allocations",type="string",JSONPath=".status.committedResourceReservation.allocations",priority=1
// +kubebuilder:printcolumn:name="HA Allocations",type="string",JSONPath=".status.failoverReservation.allocations",priority=1

// Reservation is the Schema for the reservations API
type Reservation struct {
Expand Down
36 changes: 36 additions & 0 deletions helm/library/cortex/files/crds/cortex.cloud_reservations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,42 @@ spec:
- jsonPath: .status.conditions[?(@.type=='Ready')].status
name: Ready
type: string
- jsonPath: .spec.committedResourceReservation.resourceGroup
name: ResourceGroup
type: string
- jsonPath: .spec.committedResourceReservation.projectID
name: Project
type: string
- jsonPath: .spec.availabilityZone
name: AZ
type: string
- jsonPath: .spec.startTime
name: StartTime
priority: 1
type: string
- jsonPath: .spec.endTime
name: EndTime
type: string
- jsonPath: .spec.resources
name: Resources
priority: 1
type: string
- jsonPath: .status.failoverReservation.lastChanged
name: LastChanged
priority: 1
type: date
- jsonPath: .status.failoverReservation.acknowledgedAt
name: AcknowledgedAt
priority: 1
type: date
- jsonPath: .status.committedResourceReservation.allocations
name: CR Allocations
priority: 1
type: string
- jsonPath: .status.failoverReservation.allocations
name: HA Allocations
priority: 1
type: string
name: v1alpha1
schema:
openAPIV3Schema:
Expand Down
Loading