Skip to content

Committed resource watch fixed #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblos merged 1 commit into from
Mar 25, 2026
Merged

Committed resource watch fixed #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions internal/scheduling/reservations/commitments/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/event"
"sigs.k8s.io/controller-runtime/pkg/handler"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/predicate"
Expand Down Expand Up @@ -502,10 +503,22 @@ func (r *CommitmentReservationController) SetupWithManager(mgr ctrl.Manager, mcl
})); err != nil {
return err
}
return multicluster.BuildController(mcl, mgr).
For(&v1alpha1.Reservation{}).
WithEventFilter(commitmentReservationPredicate).
Named("commitment-reservation").

// Use WatchesMulticluster to watch Reservations across all configured clusters
// (home + remotes). This is required because Reservation CRDs may be stored
// in remote clusters, not just the home cluster. Without this, the controller
// would only see reservations in the home cluster's cache.
bldr := multicluster.BuildController(mcl, mgr)
bldr, err := bldr.WatchesMulticluster(
&v1alpha1.Reservation{},
&handler.EnqueueRequestForObject{},
commitmentReservationPredicate,
)
if err != nil {
return err
}

return bldr.Named("commitment-reservation").
WithOptions(controller.Options{
// We want to process reservations one at a time to avoid overbooking.
MaxConcurrentReconciles: 1,
Expand Down
Loading