Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Branch Existence Check: FailedFound 6 issue(s) in
|
9af70cd to
e5330a2
Compare
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
rmloveland
left a comment
There was a problem hiding this comment.
LGTM, had some feedback but nothing blocking
| <p class="feature-summary">Prevent auto-unlock of schema_locked tables</p> | ||
| <p class="feature-description">A new cluster setting <code>sql.schema.auto_unlock.enabled</code> controls whether DDL operations automatically unlock <code>schema_locked</code> tables. When set to <code>false</code>, DDL on schema-locked tables is blocked unless the user manually unlocks the table first. This allows customers using LDR to enforce <code>schema_locked</code> as a hard lock preventing user-initiated DDL. The default is <code>true</code>, preserving existing behavior.</p> | ||
| <p class="feature-summary">Schema lock enforcement</p> | ||
| <p class="feature-description">The cluster setting <code>sql.schema.auto_unlock.enabled</code> controls whether DDL operations automatically unlock <code>schema_locked</code> tables. When set to <code>false</code>, DDL statements on schema-locked tables are blocked unless manually unlocked. This allows users of Logical Data Replication (LDR) to enforce <code>schema_locked</code> as a hard lock preventing user-initiated DDL. The default is <code>true</code>.</p> |
There was a problem hiding this comment.
i'm not sure if it's worth adding this level of nuance in a feature highlight (cc @rafiss if you have opinions) - in the docs PR we made it clear that it can't always auto-unlock
suggest clarifying slightly with replacement text something like the following (IFF we care about this level of nuance, which i think we will, since it could lead to some user/support interactions re: "why doesn't this auto-unlock?"):
<p class="feature-description">The cluster setting <code>sql.schema.auto_unlock.enabled</code> controls whether DDL operations attempt to automatically unlock and re-lock <code>schema_locked</code> tables. When set to <code>false</code>, DDL statements on schema-locked tables are blocked unless manually unlocked. This allows users of Logical Data
Replication (LDR) to enforce <code>schema_locked</code> as a hard lock preventing user-initiated DDL. Some schema changes still require manual unlock even when this setting is <code>true</code>. The default is <code>true</code>.</p>
jhlodin
left a comment
There was a problem hiding this comment.
Suggested links and left a few comments, otherwise LGTM for my topic areas
jhlodin
left a comment
There was a problem hiding this comment.
Updating my review with suggestions for Cloud content specifically
jhlodin
left a comment
There was a problem hiding this comment.
Need to remove 2DC active-passive which was bumped to Q2
| {% endcomment %} | ||
| - `ALTER TABLE ... DROP CONSTRAINT` can now be used to drop `UNIQUE` constraints. The backing `UNIQUE` index will also be dropped, as CockroachDB treats the constraint and index as the same thing. [#162345](https://github.com/cockroachdb/cockroach/pull/162345) | ||
|
|
||
| - Added the <a href="{% link v26.2/cluster-settings.md %}#setting-sql-stats-canary-fraction"><code>sql.stats.canary_fraction</code></a> cluster setting to enable <a href="{% link v26.2/canary-statistics.md %}">canary table statistics</a>. This setting controls the probability that table statistics will use canary mode (i.e., always use the freshest stats) instead of stable mode (i.e., use the second-freshest stats) for query planning `[0.0-1.0]`. [#167944](https://github.com/cockroachdb/cockroach/pull/167944) |
There was a problem hiding this comment.
@peachdawnleach Do you mind reviewing this and the following 2 items on canary stats? I learned that the entire feature is version-gated, so moved more release notes to this section and also reworded them a bit in the process.
@jhlodin Done; PTAL! |
e50dea3 to
e03bb66
Compare
dbfa1b4 to
5304f13
Compare
Draft 26.2.0 GA release notes. Note: