This repository was archived by the owner on Jan 23, 2025. It is now read-only.
ui-components: updated the icon-container class so that it vertically aligns the icon within its container#552
Open
ryanluu12345 wants to merge 1 commit intomasterfrom
Open
Conversation
… aligns the icon within its container Previously, the icon was not centered with the text. With this change, it is now centered vertically. Release Note: None
laurenbarker
approved these changes
Aug 21, 2024
Collaborator
laurenbarker
left a comment
laurenbarker
left a comment
There was a problem hiding this comment.
Sorry for the huge lag here 😓 LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the icon was not centered with the text. With this change, it is now centered vertically.
Release Note: None
Before
After
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @cockroachlabs/ui-components@0.7.15-canary.552.8989548377.0 # or yarn add @cockroachlabs/ui-components@0.7.15-canary.552.8989548377.0