Add FileDescriptor#imports and #public_imports#16
Merged
Conversation
Resolve a file's dependency filenames to their FileDescriptors so generators can follow imports (e.g. to emit require/import statements). #public_imports returns the subset declared with 'import public'. Imports not included in the request are omitted. Mark article.proto's comment.proto import as public in the fixtures (and regenerate) to cover public imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a file's imports to their descriptors so generators can follow them — e.g. to emit language-level
import/requirestatements for each dependency.Changes
FileDescriptor#imports— the file'sdependencyfilenames resolved toFileDescriptors. Imports not included in the request are omitted.#public_imports— the subset declared withimport public(resolved viapublic_dependency).Testing
#importsresolves toFileDescriptors in declaration order,#public_importsreturns only theimport publicsubset, and a file with no dependencies yields empty arrays.article.proto'scomment.protoimport asimport publicin the blog fixtures (and regenerated viabin/fixtures) to cover public imports.bin/rake(test + rubocop): 76 runs, 200 assertions, 0 failures, rubocop clean.