fix(agent): fall back to random machine-id when setup fails#6
Merged
Conversation
…tup fails regenMachineID truncates /etc/machine-id before running the setup tool; a setup failure previously returned an error with the file left empty. Now any setup failure falls through to writeRandomMachineID, which is what the tool would generate anyway absent other sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-up on #4:
regenMachineIDtruncates/etc/machine-idthen runssystemd-machine-id-setup; if the tool exists but fails, the guest was left with an empty machine-id (error returned, damage done). Any setup failure now falls through towriteRandomMachineID()— the same random 32-hex the tool itself generates absent other sources. Only if that write also fails does an error (and the empty file) surface.lint 0 issues × 3 GOOS, tests green. No dedicated unit test: the branch writes the real
/etc/machine-id; making the path injectable for a 3-line fallback would be overdesign.