fix(vm): stop leaking the VNC password + unify CNI-VNC gate#16
Merged
Conversation
- VNCPass is launch-scoped and set from the flag on every start, but it was persisted to vm.json (json tag) and echoed by inspect/list — a plaintext password at rest. Mark it json:"-". - setVNCPassword embedded the full HMP dialogue in its error, which echoes the typed 'set_password vnc <pw>' line to stderr/CI logs. Return a static error instead. - startVNCProxy left an orphan proxy holding the host port if WritePIDFile failed after the child forked; kill it on that path. - The mandatory-password gate was hand-duplicated at create/clone/launch; extract requireCNIVNCPassword and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial-review findings on tonight's VNC-over-proxy feature.
Security
vm.jsonand echoed byvm inspect/vm list -o json, though it's launch-scoped and re-set from the flag every start — never read back. Nowjson:"-"(runpasses the in-memory record to launch, so the in-process value is untouched).fmt.Errorf("qemu: %s", out)embedded the HMP echo ofset_password vnc <pw>, landing in stderr/CI logs. Static error now.Robustness
WritePIDFilefailure after the proxy forked left an unreapable child holding the host VNC port. Kill it on that path.requireCNIVNCPassword+TestRequireCNIVNCPasswordso a future refactor can't silently drop the off-box-exposure guard.Verification
GOWORK=off build/test/
-racegreen; lint 0 issues both GOOS; fmt-check clean. No behavior change beyond the security fixes.