feat: OCI-only registry backend (drop epoch)#12
Merged
Merged
Conversation
buildRegistry returns a cocoon-common oci.Registry client when OCI_REGISTRY is set (GCP ADC then docker config), else the epoch registryclient backend, so the reconcilers' manifest probe + rollback run against Artifact Registry without epoch (issue #25). epoch is now imported only for the transitional backend.
The field now holds either an OCI client or the epoch backend, so Epoch is misleading; Registry matches its snapshot.Registry type and the vk naming. Mechanical rename, no behavior change.
buildRegistry now requires OCI_REGISTRY and always builds a cocoon-common oci client (GCP ADC then docker config); the registryclient fallback and EPOCH_URL/TOKEN are gone, and epoch is removed from go.mod. Neutralizes epoch references in comments, an event, and the README. Bumps cocoon-common to the HasBlob/ImportImage rename.
CMGS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the operator's reconcilers an OCI registry backend for the snapshot
existence probe (
HasManifest) and hibernate rollback (DeleteManifest), anddrops epoch entirely — the operator now imports zero epoch. Counterpart to
vk-cocoon#26. Advances #25.
Depends on cocoon-common#4 (the shared
ocipackage). Pinned viago get cocoon-common@<sha>; moves to a tagged release once #4 merges.What changed
buildRegistryrequiresOCI_REGISTRYand builds acocoon-common/ociclient (GCP ADC viagoogle.Keychain, then docker config). No epoch fallback.Epochfield renamed →Registry(it holds the OCI client; matches thesnapshot.Registrytype).registryclientimport +EPOCH_URL/TOKEN; epoch is gone fromgo.mod. Neutralized epoch references in comments, an event, and the README.Deploy note
OCI_REGISTRYis now required — deploy after the epoch→AR data migration completes and the env is set. Merging the PR does not deploy.Quality
Each commit:
build(go.work+GOWORK=off) /vet/test/lint(darwin + linux, 0) green, plus/code+/simplify. No trailers.