Skip to content

Improve issue with start/end lines when they switch #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DMarinhoCodacy merged 1 commit into from
Jun 2, 2026
Merged

Improve issue with start/end lines when they switch #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/scala/com/codacy/duplication/jscpd/Jscpd.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,14 @@ object Jscpd extends DuplicationTool {
val filePath = o("name").as[String]
val startLine = o("start").as[Int]
val endLine = o("end").as[Int]
// We found a bug in jscpd where the startLine is, sometimes, bigger than the endLine
// so we need to normalize that
val normalizedStartLine = math.min(startLine, endLine)
val normalizedEndLine = math.max(startLine, endLine)
DuplicationCloneFile(
filePath = filePath,
startLine = startLine,
endLine = endLine
startLine = normalizedStartLine,
endLine = normalizedEndLine
)
})
)
Expand All @@ -89,4 +93,4 @@ object Jscpd extends DuplicationTool {
}
}

object Main extends DockerDuplication(Jscpd)()
object Main extends DockerDuplication(Jscpd)()