feat: add #[codama(skip)] directive for all enum variants#80
Merged
lorisleiva merged 3 commits intocodama-idl:mainfrom Mar 5, 2026
Merged
feat: add #[codama(skip)] directive for all enum variants#80lorisleiva merged 3 commits intocodama-idl:mainfrom
lorisleiva merged 3 commits intocodama-idl:mainfrom
Conversation
Extend #[codama(skip)] support beyond instruction enum variants to also work on account and error enum variants, keeping discriminator counting consistent when variants are skipped.
lorisleiva
reviewed
Mar 4, 2026
Member
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments to keep things consistent.
Contributor
Author
|
Good catches. I think bd39202 should cover those @lorisleiva. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[codama(skip)]support for account and error and instruction variants.Usage
In practice (escrow program — skipping an internal CPI event emitter):
Works on
CodamaAccountsandCodamaErrorsenums with the same semantics.Test plan
cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test