Skip to content

Integrate @codama/spec@1.7.0#1013

Open
lorisleiva wants to merge 1 commit into
mainfrom
loris/integrate-spec-1.7.0
Open

Integrate @codama/spec@1.7.0#1013
lorisleiva wants to merge 1 commit into
mainfrom
loris/integrate-spec-1.7.0

Conversation

@lorisleiva

Copy link
Copy Markdown
Member

Integrates @codama/spec@1.7.0-rc.0 into the TS codegen pipeline and regenerates @codama/node-types, @codama/nodes, and @codama/visitors-core with the new presentation layer (display nodes, provide/inject, account-field selector).

Held against main for CI and review but not merged until the spec stabilises at 1.7.0 — letting us bump to later RCs here as the spec evolves. No changeset is included for the same reason.

Key changes:

  • anyNode TypeExpr: both typeExpr.ts fragments render it as the top-level Node type; the visitor generator visits-and-asserts it against REGISTERED_NODE_KINDS.
  • Config maps (CATEGORY_DIRECTORIES, GENERIC_PARAM_ORDER, walk-order maps, NODE_CONFIGS) absorb the new display/provides attributes; a paramName-only AttributeOverride variant renames providedNode.node so it doesn't shadow the visitor's node parameter.
  • Input-type generator now widens every stringIdentifier() attribute to string (not just name).
  • Visitor fixes: getByteSizeVisitor/getMaxByteSizeVisitor add visitStringType => null now that stringTypeNode is no longer a leaf; getDebugStringVisitor drops the trailing () for childless nodes; dynamic-codecs adds visitInjectedValue that throws (injected values must be resolved before codec time).
  • Tests: 11 new per-node fixtures for the new spec kinds, plus anyNode unit tests.

Lint, build, and test pass across all 17 packages.

@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f4d3892

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lorisleiva commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Codama’s TypeScript codegen pipeline to align with @codama/spec@1.7.0-rc.0, regenerating node/type definitions and visitor implementations to support the new presentation layer (display nodes) and provide/inject semantics.

Changes:

  • Bumps @codama/spec to 1.7.0-rc.0 and regenerates @codama/node-types, @codama/nodes, and @codama/visitors-core.
  • Adds new node kinds (e.g., providedNode, injectedValueNode, display nodes) and updates visitor generation/walk order to traverse new attributes (display, provides).
  • Updates byte-size/debug visitors and adds/updates tests and fixtures for new kinds and adjusted debug-string formatting.

Reviewed changes

Copilot reviewed 30 out of 104 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Locks @codama/spec to 1.7.0-rc.0.
packages/spec-generators/package.json Bumps generator dependency to @codama/spec@1.7.0-rc.0.
packages/spec-generators/src/shared/defaults.ts Extends generator defaults for new categories/attributes and generic ordering.
packages/spec-generators/src/nodeTypes/fragments/typeExpr.ts Renders anyNode() as top-level Node for node-types generation.
packages/spec-generators/src/nodes/fragments/typeExpr.ts Routes anyNode() to Node from @codama/node-types.
packages/spec-generators/src/nodes/fragments/inputType.ts Widens all stringIdentifier() attributes to string in generated Input types.
packages/spec-generators/src/nodes/config.ts Adds constructor override for providedNode to avoid node parameter shadowing.
packages/spec-generators/src/visitorsCore/walkStep.ts Introduces anyNode child-shape classification for visitor generation.
packages/spec-generators/src/visitorsCore/options.ts Updates merge/identity walk orders to include provides and display.
packages/spec-generators/src/visitorsCore/fragments/mergeCollect.ts Ensures merge visitor collects anyNode-shaped children.
packages/spec-generators/src/visitorsCore/fragments/identityWalkStep.ts Adds identity-walk support for anyNode() with registered-kind assertions.
packages/spec-generators/test/nodeTypes/fragments/typeExpr.test.ts Adds anyNode() rendering test for node-types fragment output.
packages/spec-generators/test/nodes/fragments/typeExpr.test.ts Adds anyNode() routing test for nodes fragment output.
packages/spec-generators/test/nodes/fragments/nodeTypeParameters.test.ts Updates generic parameter ordering expectations to include display.
packages/nodes/src/generated/index.ts Exports new generated nodes, including ProvidedNode and displayNodes.
packages/nodes/src/generated/codamaVersion.ts Updates supported Codama version to 1.7.0.
packages/nodes/src/generated/nodeKinds.ts Registers new node kinds (providedNode, display nodes).
packages/nodes/src/generated/ProvidedNode.ts Adds providedNode constructor for provide/inject graph.
packages/nodes/src/generated/valueNodes/InjectedValueNode.ts Adds injectedValueNode constructor with optional fallback.
packages/nodes/src/generated/valueNodes/InjectableStringValueNode.ts Adds injectable string value kind list constant.
packages/nodes/src/generated/valueNodes/InjectableNumberValueNode.ts Adds injectable number value kind list constant.
packages/nodes/src/generated/valueNodes/StandaloneValueNode.ts Treats injectedValueNode as a standalone value node kind.
packages/nodes/src/generated/valueNodes/index.ts Exports new value-node helpers/types.
packages/nodes/src/generated/contextualValueNodes/AccountFieldValueNode.ts Adds accountFieldValueNode constructor for account-field selectors.
packages/nodes/src/generated/contextualValueNodes/StandaloneContextualValueNode.ts Includes accountFieldValueNode as standalone contextual value kind.
packages/nodes/src/generated/contextualValueNodes/index.ts Exports new contextual value node.
packages/nodes/src/generated/typeNodes/StringTypeNode.ts Adds optional display child to string type nodes.
packages/nodes/src/generated/typeNodes/NumberTypeNode.ts Adds optional display child to number type nodes.
packages/nodes/src/generated/typeNodes/StructFieldTypeNode.ts Adds optional display child to struct field type nodes.
packages/nodes/src/generated/typeNodes/EnumEmptyVariantTypeNode.ts Adds optional display child to empty enum variants.
packages/nodes/src/generated/typeNodes/EnumStructVariantTypeNode.ts Adds optional display child to struct enum variants.
packages/nodes/src/generated/typeNodes/EnumTupleVariantTypeNode.ts Adds optional display child to tuple enum variants.
packages/nodes/src/generated/InstructionAccountNode.ts Adds optional accountLink and display children to instruction accounts.
packages/nodes/src/generated/InstructionArgumentNode.ts Adds optional display child to instruction arguments.
packages/nodes/src/generated/InstructionRemainingAccountsNode.ts Adds optional display child to remaining-accounts node.
packages/nodes/src/generated/InstructionNode.ts Adds provides and display fields to instructions.
packages/nodes/src/generated/displayNodes/index.ts Introduces display-node module exports.
packages/nodes/src/generated/displayNodes/RegisteredDisplayNode.ts Defines the registered display node kinds.
packages/nodes/src/generated/displayNodes/DisplayNode.ts Provides composable display-node kinds list.
packages/nodes/src/generated/displayNodes/NumberDisplayNode.ts Declares supported number-display node kinds.
packages/nodes/src/generated/displayNodes/StringDisplayNode.ts Adds stringDisplayNode constructor.
packages/nodes/src/generated/displayNodes/StructFieldDisplayNode.ts Adds structFieldDisplayNode constructor.
packages/nodes/src/generated/displayNodes/EnumVariantDisplayNode.ts Adds enumVariantDisplayNode constructor.
packages/nodes/src/generated/displayNodes/AmountNumberDisplayNode.ts Adds amountNumberDisplayNode constructor.
packages/nodes/src/generated/displayNodes/DateTimeNumberDisplayNode.ts Adds dateTimeNumberDisplayNode constructor.
packages/nodes/src/generated/displayNodes/DurationNumberDisplayNode.ts Adds durationNumberDisplayNode constructor.
packages/nodes/src/generated/displayNodes/InstructionDisplayNode.ts Adds instructionDisplayNode constructor.
packages/nodes/src/generated/displayNodes/InstructionAccountDisplayNode.ts Adds instructionAccountDisplayNode constructor.
packages/node-types/src/generated/index.ts Exposes new types including ProvidedNode and display-node types.
packages/node-types/src/generated/Node.ts Extends Node union to include ProvidedNode and registered display nodes.
packages/node-types/src/generated/shared/codamaVersion.ts Updates CodamaVersion to 1.7.0.
packages/node-types/src/generated/shared/index.ts Exports new shared displaySkip type.
packages/node-types/src/generated/shared/displaySkip.ts Introduces DisplaySkip semantics for fallback display rendering.
packages/node-types/src/generated/ProvidedNode.ts Adds ProvidedNode interface.
packages/node-types/src/generated/valueNodes/InjectedValueNode.ts Adds InjectedValueNode interface with optional fallback.
packages/node-types/src/generated/valueNodes/InjectableStringValueNode.ts Adds injectable string value union type.
packages/node-types/src/generated/valueNodes/InjectableNumberValueNode.ts Adds injectable number value union type.
packages/node-types/src/generated/valueNodes/StandaloneValueNode.ts Includes InjectedValueNode in standalone value union.
packages/node-types/src/generated/valueNodes/index.ts Exports new value-node types.
packages/node-types/src/generated/contextualValueNodes/AccountFieldValueNode.ts Adds AccountFieldValueNode interface.
packages/node-types/src/generated/contextualValueNodes/StandaloneContextualValueNode.ts Includes account-field value node in standalone contextual values.
packages/node-types/src/generated/contextualValueNodes/index.ts Exports new contextual value-node types.
packages/node-types/src/generated/typeNodes/StringTypeNode.ts Adds display?: StringDisplayNode to string type nodes.
packages/node-types/src/generated/typeNodes/NumberTypeNode.ts Adds display?: NumberDisplayNode to number type nodes.
packages/node-types/src/generated/typeNodes/StructFieldTypeNode.ts Adds display?: StructFieldDisplayNode to struct field type nodes.
packages/node-types/src/generated/typeNodes/EnumEmptyVariantTypeNode.ts Adds display?: EnumVariantDisplayNode to empty enum variants.
packages/node-types/src/generated/typeNodes/EnumStructVariantTypeNode.ts Adds display?: EnumVariantDisplayNode to struct enum variants.
packages/node-types/src/generated/typeNodes/EnumTupleVariantTypeNode.ts Adds display?: EnumVariantDisplayNode to tuple enum variants.
packages/node-types/src/generated/InstructionAccountNode.ts Adds optional accountLink and display to instruction accounts.
packages/node-types/src/generated/InstructionArgumentNode.ts Adds optional display to instruction arguments.
packages/node-types/src/generated/InstructionRemainingAccountsNode.ts Adds optional display to remaining accounts.
packages/node-types/src/generated/InstructionNode.ts Adds provides?: ProvidedNode[] and display?: InstructionDisplayNode.
packages/node-types/src/generated/displayNodes/index.ts Exports display-node interfaces and unions.
packages/node-types/src/generated/displayNodes/RegisteredDisplayNode.ts Defines RegisteredDisplayNode union.
packages/node-types/src/generated/displayNodes/DisplayNode.ts Defines DisplayNode as composable registered display node.
packages/node-types/src/generated/displayNodes/NumberDisplayNode.ts Defines number-display union type.
packages/node-types/src/generated/displayNodes/StringDisplayNode.ts Adds StringDisplayNode interface.
packages/node-types/src/generated/displayNodes/StructFieldDisplayNode.ts Adds StructFieldDisplayNode interface.
packages/node-types/src/generated/displayNodes/EnumVariantDisplayNode.ts Adds EnumVariantDisplayNode interface.
packages/node-types/src/generated/displayNodes/AmountNumberDisplayNode.ts Adds AmountNumberDisplayNode interface.
packages/node-types/src/generated/displayNodes/DateTimeNumberDisplayNode.ts Adds DateTimeNumberDisplayNode interface.
packages/node-types/src/generated/displayNodes/DurationNumberDisplayNode.ts Adds DurationNumberDisplayNode interface.
packages/node-types/src/generated/displayNodes/InstructionDisplayNode.ts Adds InstructionDisplayNode interface.
packages/node-types/src/generated/displayNodes/InstructionAccountDisplayNode.ts Adds InstructionAccountDisplayNode interface.
packages/visitors-core/src/getByteSizeVisitor.ts Prevents string types from being treated as fixed-size when they gain display.
packages/visitors-core/src/getMaxByteSizeVisitor.ts Prevents string types from being treated as fixed max-size when they gain display.
packages/visitors-core/src/getDebugStringVisitor.ts Removes trailing () for nodes with no rendered children.
packages/visitors-core/src/generated/mergeVisitor.ts Updates generated traversal to include new display/provides/injection nodes.
packages/visitors-core/src/generated/identityVisitor.ts Updates generated rebuild logic for new optional children (display, provides, etc.).
packages/visitors-core/src/generated/nodeTestPaths.ts Adds test-path entries for newly introduced node kinds.
packages/visitors-core/test/mergeVisitor.test.ts Updates expectations affected by debug-string formatting change.
packages/visitors-core/test/mapVisitor.test.ts Updates string-length expectations due to debug-string formatting change.
packages/visitors-core/test/nodes/ProvidedNode.test.ts Adds per-node visitor fixture tests for providedNode.
packages/visitors-core/test/nodes/valueNodes/InjectedValueNode.test.ts Adds per-node visitor fixture tests for injectedValueNode.
packages/visitors-core/test/nodes/contextualValueNodes/AccountFieldValueNode.test.ts Adds per-node visitor fixture tests for accountFieldValueNode.
packages/visitors-core/test/nodes/displayNodes/AmountNumberDisplayNode.test.ts Adds per-node visitor fixture tests for amountNumberDisplayNode.
packages/visitors-core/test/nodes/displayNodes/DateTimeNumberDisplayNode.test.ts Adds per-node visitor fixture tests for dateTimeNumberDisplayNode.
packages/visitors-core/test/nodes/displayNodes/DurationNumberDisplayNode.test.ts Adds per-node visitor fixture tests for durationNumberDisplayNode.
packages/visitors-core/test/nodes/displayNodes/EnumVariantDisplayNode.test.ts Adds per-node visitor fixture tests for enumVariantDisplayNode.
packages/visitors-core/test/nodes/displayNodes/InstructionAccountDisplayNode.test.ts Adds per-node visitor fixture tests for instructionAccountDisplayNode.
packages/visitors-core/test/nodes/displayNodes/InstructionDisplayNode.test.ts Adds per-node visitor fixture tests for instructionDisplayNode.
packages/visitors-core/test/nodes/displayNodes/StringDisplayNode.test.ts Adds per-node visitor fixture tests for stringDisplayNode.
packages/visitors-core/test/nodes/displayNodes/StructFieldDisplayNode.test.ts Adds per-node visitor fixture tests for structFieldDisplayNode.
packages/dynamic-codecs/src/values.ts Throws on injectedValueNode during codec evaluation to enforce prior resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/spec-generators/src/nodes/fragments/inputType.ts Outdated
Comment thread packages/dynamic-codecs/src/values.ts Outdated
Integrates `@codama/spec@1.7.0-rc.0` into the TS codegen pipeline and regenerates `@codama/node-types`, `@codama/nodes`, and `@codama/visitors-core` with the new presentation layer (display nodes, provide/inject, account-field selector).

Held against `main` for CI and review but not merged until the spec stabilises at `1.7.0` — letting us bump to later RCs here as the spec evolves. No changeset is included for the same reason.

Key changes:
- `anyNode` TypeExpr: both `typeExpr.ts` fragments render it as the top-level `Node` type; the visitor generator visits-and-asserts it against `REGISTERED_NODE_KINDS`.
- Config maps (`CATEGORY_DIRECTORIES`, `GENERIC_PARAM_ORDER`, walk-order maps, `NODE_CONFIGS`) absorb the new `display`/`provides` attributes; a `paramName`-only `AttributeOverride` variant renames `providedNode.node` so it doesn't shadow the visitor's `node` parameter.
- Input-type generator now widens every `stringIdentifier()` attribute to `string` (not just `name`).
- Visitor fixes: `getByteSizeVisitor`/`getMaxByteSizeVisitor` add `visitStringType => null` now that `stringTypeNode` is no longer a leaf; `getDebugStringVisitor` drops the trailing `()` for childless nodes; `dynamic-codecs` adds `visitInjectedValue` that throws (injected values must be resolved before codec time).
- Tests: 11 new per-node fixtures for the new spec kinds, plus `anyNode` unit tests.

Lint, build, and test pass across all 17 packages.
@lorisleiva lorisleiva force-pushed the loris/integrate-spec-1.7.0 branch from 644d297 to f4d3892 Compare July 8, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants