AI: opponent first integration by lisambet · Pull Request #63 · codastream/transcendence

lisambet · 2026-02-03T14:23:49Z

This pull request introduces a new RL-trained Pong AI service and integrates it throughout the stack, enabling users to play against an AI opponent. It adds new backend endpoints for AI interaction, updates the gateway to proxy AI-related requests, and enhances the frontend to support AI game sessions. Additionally, it includes supporting infrastructure updates, such as Docker and service orchestration, and some dependency upgrades.

Pong AI Service Integration

Added a new pong-ai-service to both docker-compose.yml and dev-docker-compose.yml, including build context, environment variables, healthcheck, and model volume mounting. [1] [2]
Added a Dockerfile and a README.md for the Pong AI service, describing setup, training, API, and usage. [1] [2]

Backend API Enhancements for RL/AI

Implemented new endpoints in the game backend for RL/AI integration: /rl/reset, /rl/step, and /rl/state for game session management and step-wise control. [1] [2] [3]
Extended the GameState interface and game engine to expose ball velocity, needed for RL environments. [1] [2]

Gateway and Proxy Updates

Added a new controller and route registration in the gateway to proxy /pong-ai/join-game requests to the Pong AI service, supporting both GET and POST. [1] [2]
Updated gateway constants to allowlist new RL endpoints for rate limiting and CORS.

Frontend (Game UI) Enhancements

Added a "Create game with AI" button and implemented the workflow to create a session, invite the AI, and display status/logs to the user. [1] [2] [3]

Infrastructure and Miscellaneous

Updated Makefile to support building, shell access, and logs for the new Pong AI service. [1] [2] [3]
Upgraded several dependencies in package.json and package-lock.json for improved compatibility and security. [1] [2] [3] [4] [5]

These changes collectively enable a user to play against a reinforcement learning-based AI opponent in Pong, with all necessary backend, proxy, and frontend support.

- bypass auth check for /health in UM - undo eslint fix in gateway

- Add pong-ai-service to docker-compose and dev-compose - Fix healthcheck to use GET instead of HEAD - Add environment variables to .env - Update requirements.txt with missing dependencies

Lisambet

…odify AI invitation logic

Lisambet

fix: kept these chages for later

ai-opponent integration

lisambet · 2026-02-03T14:25:48Z

@copilot

Copilot · 2026-02-03T14:25:57Z

@lisambet I've opened a new pull request, #64, to work on those changes. Once the pull request is ready, I'll request review from you.

…ation

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 13 comments.

Comments suppressed due to low confidence (1)

srcs/gateway/src/controllers/health.controller.ts:64

In healthAllHandler, results[name] is used inside the services.map(...) callback, but name is no longer defined after switching from Object.entries(SERVICES) to Object.values(SERVICES). This will either fail TypeScript compilation or throw a ReferenceError at runtime, and also means your results object is never populated under the intended service keys. You likely want to restore iteration over [name, service] entries or derive a key (e.g. the map key or serviceKey) and use that consistently for both success and error branches.

        const res = await fetch(`https://${service.host}:${service.port}/health`, fetchOptions);
        results[name] = res.status === 200 ? 'healthy' : 'unhealthy';
      } catch (error) {
        results[name] = `unhealthy (error: ${(error as Error).message})`;
      }

srcs/dev-docker-compose.yml

Copilot · 2026-02-04T13:25:47Z

srcs/pong-ai/pong_server.py

+        self.model_path = model_path
+        self.model: Optional[PPO] = None
+        self.sessions: Dict[str, GameSession] = {}
+        self.load_model()
+


AIService can leave self.model as None when load_model doesn’t find or fails to load a checkpoint, but downstream GameSession instances created from this service call get_ai_action() which blindly does self.model.predict(...). This will raise an AttributeError at runtime as soon as the RL WebSocket/session endpoints try to use the model. Consider either preventing session creation when no model is loaded, or explicitly handling the missing-model case (e.g. by failing fast with a clear error or initializing a fresh model) instead of passing None into GameSession.

Copilot · 2026-02-04T13:25:47Z

srcs/pong-ai/pong_server.py

+            "ball_x": float(self.env.ball_x),
+            "ball_y": float(self.env.ball_y),
+            "ball_vx": float(self.env.ball_vx),
+            "ball_vy": float(self.env.ball_vy),
+            "ai_paddle_y": float(self.env.ai_paddle_y),


GameSession.step() assumes the environment exposes attributes like player_paddle_y, ball_x, ball_y, ball_vx, and ball_vy, but the PongEnv implementation in this service only returns observations via _convert_state and never defines these attributes. As written, any call to step() will raise AttributeError on the PongEnv instance, so the /session/create and /ws/game/{session_id} endpoints cannot function correctly. You should either adapt GameSession to work with PongEnv’s API (e.g. operate purely on the observation vector) or extend PongEnv to maintain and expose the fields GameSession expects.

Copilot · 2026-02-04T13:25:47Z

srcs/pong-ai/pong_server.py

+
+        return {
+            "status": "success",
+            "session_id": session_id,
+            "message": "AI player joined the game",
+            "paddle": "right"
+        }
+
+    except Exception as e:
+        raise HTTPException(status_code=500, detail=str(e))


This join_game handler has two except Exception as e blocks in a row, and the return after raise HTTPException is unreachable, which makes the control flow confusing and redundant. The second except will never be hit, and the dead return path suggests an earlier implementation that wasn’t fully cleaned up. It would be clearer and less error-prone to keep a single except block here and remove the unreachable return code.

Suggested change

return {

"status": "success",

"session_id": session_id,

"message": "AI player joined the game",

"paddle": "right"

}

except Exception as e:

raise HTTPException(status_code=500, detail=str(e))

srcs/pong-ai/ai_player.py

srcs/pong-ai/pong_server.py

Copilot · 2026-02-04T13:25:49Z

srcs/pong-ai/pong_server.py

+
+    def load_model(self):
+        try:
+            import os


This import of module os is redundant, as it was previously imported on line 5.

Suggested change

import os

Copilot · 2026-02-04T13:25:49Z

srcs/pong-ai/pong_server.py

+    except Exception as e:
+        raise HTTPException(status_code=500, detail=str(e))


This except block handling Exception is unreachable; as this except block also handles Exception.

Suggested change

except Exception as e:

raise HTTPException(status_code=500, detail=str(e))

srcs/pong-ai/Dockerfile

srcs/game/src/controllers/game.controller.ts

srcs/game/src/core/game.engine.ts

codastream · 2026-02-06T16:43:45Z

srcs/game/src/core/game.types.ts

@@ -1 +1 @@
 import { Vector2 } from './game.vector.js';


remove import
ESLint extension in VSCode can be set up with "Fix all auto-fixable problems"

Suggested change

srcs/game/src/routes/game.routes.ts

Ilia1177 · 2026-02-06T22:53:58Z

srcs/gateway/src/utils/constants.ts

    '/api/users/health',
    '/api/game/health',
    '/api/block/health',
+    '/api/game/create-session',


Je pense pas que cette route devrait etre dans les PUBLIC_ROUTES. Creer une game session necessite de l'utilisateur qu il soit enregistré.

Ilia1177 · 2026-02-06T22:54:35Z

srcs/nginx/src/service/GameDisplay.ts

Ces displayProvider.ts sont amené a disparaitre au profit de l'implementation REACT

codastream

Hâte de le voir s'entrainer et fonctionner avec game.
Il faudrait probablement régler avant de fusionner certains points

adapter le service en wss
la cohérence des données renvoyées par env et la manière dont elles sont lues dans server
éviter d'ajouter des erreurs ESLint : unused imports, no any, ...

Ainsi que

l'architecture API : pourquoi get et post pour join-game ? utiliser un préfixe plus court ?
le découpage des classes (faire une pour la connexion)
éviter d'avoir trop de code en dur pour les url, ports, actions, ...
vérifier les deps (requests, pygame) + fixer les versions
validation des données entrantes (pydantic ?)

Et quelques optimisations pour maintenant ou plus tard

timeout et resiliency patterns (reconnexion, ..)
normalisation des valeurs

srcs/gateway/src/controllers/health.controller.ts

codastream · 2026-02-07T11:39:16Z

srcs/gateway/src/controllers/health.controller.ts

@@ -1,2 +1,2 @@
 import { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
 import { logger } from '../utils/logger.js';


Suggested change

tu veux que je supprimes import { logger } from '../utils/logger.js'; n'est-ce pas ?

srcs/gateway/src/controllers/health.controller.ts

codastream · 2026-02-07T11:43:39Z

srcs/gateway/src/controllers/health.controller.ts

Suggested change

export async function healthAllHandler(req: FastifyRequest) {

codastream · 2026-02-07T11:47:01Z

srcs/gateway/src/controllers/pong-ai.controller.ts

+  });
+
+  // POST version - accepts sessionId in body
+  app.post('/join-game', async (request, reply) => {


quel est l'intérêt d'avoir 2 routes pour join game ? POST est peut-être plus approprié

codastream · 2026-02-07T15:15:45Z

srcs/pong-ai/pong_server.py

+                "message": "AI is already in this game"
+            }
+
+        # Create AI player


il faudrait trouver un mécanisme pour supprimer les AIPlayer
bloc finally dans webSocket game selon Gemini

codastream · 2026-02-07T15:21:56Z

srcs/pong-ai/pong_server.py

+            self.model = None
+
+    def create_session(self, session_id: str) -> GameSession:
+        if session_id in self.sessions:


Suggested change

if session_id in self.sessions:

if self.model is None:

raise RuntimeError("No model")

if session_id in self.sessions:

srcs/dev-docker-compose.yml

codastream · 2026-02-07T15:24:49Z

.gitignore

je ne sais pas comment fonctionnent les checkpoints. il doit y avoir moyen de reduire leur nombre

c'est fait!

codastream · 2026-02-07T15:25:01Z

Makefile

 	$(D_COMPOSE) up -d --build $(GAME_SERVICE_NAME)
 block:
 	$(D_COMPOSE) up -d --build $(BK_SERVICE_NAME)
+pong:


you are right!

Makefile docs/pong-ai.md srcs/dev-docker-compose.yml srcs/docker-compose.yml srcs/pong-ai/Dockerfile srcs/pong-ai/ai_player.py srcs/pong-ai/requirements.txt

… pong_server

Co-authored-by: Francois <multicompte+github@outlook.fr>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ection handling in AIPlayer

codastream

si on utilise pong_500000, peut-on supprimer les autres checkpoints ?
il y a quelques erreurs de linter qui sont faciles a supprimer (unused vars)

codastream · 2026-02-12T16:47:57Z

srcs/game/src/controllers/game.controller.ts

 import { handleClientMessage } from '../service/game.communication.js';
 import { GameSettings } from '../core/game.types.js';
 import { WebSocket } from 'ws';
 import { WS_CLOSE } from '../core/game.state.js';


Suggested change

codastream · 2026-02-12T16:48:43Z

srcs/game/src/routes/game.routes.ts

  newGameSession,
  healthCheck,
  gameSettings,
+  resetGame,


Suggested change

resetGame,

codastream · 2026-02-12T16:48:50Z

srcs/game/src/routes/game.routes.ts

  healthCheck,
  gameSettings,
+  resetGame,
+  stepGame,


Suggested change

stepGame,

codastream · 2026-02-12T16:48:58Z

srcs/game/src/routes/game.routes.ts

  gameSettings,
+  resetGame,
+  stepGame,
+  getGameState,


Suggested change

getGameState,

codastream · 2026-02-12T16:49:58Z

srcs/gateway/src/controllers/pong-ai.controller.ts

@@ -0,0 +1,41 @@
+import { FastifyInstance } from 'fastify';
+import { proxyRequest, webSocketProxyRequest } from '../utils/proxy.js';


Suggested change

import { proxyRequest, webSocketProxyRequest } from '../utils/proxy.js';

import { proxyRequest } from '../utils/proxy.js';

codastream · 2026-02-12T16:51:31Z

srcs/pong-ai/Dockerfile

est-ce qu'un build multistage builder + runner ferait gagner de la place ?

ça fera ~200-300MB économisés,

…points

Francois Petit and others added 24 commits January 7, 2026 16:16

fix: nginx config + auth call to um

c3c2cc4

- bypass auth check for /health in UM - undo eslint fix in gateway

feat(pong-ai): integrate pong AI service into docker-compose

26477b8

- Add pong-ai-service to docker-compose and dev-compose - Fix healthcheck to use GET instead of HEAD - Add environment variables to .env - Update requirements.txt with missing dependencies

feat: add AI game creation button and functionality

5788bd1

fix: api routes are sending New from rAIGameSession

e18d6f8

fix: websockets are good and api receives the right messages

8bf69c3

Merge pull request #1 from lisambet/lisambet

243e02a

Lisambet

Merge branch 'main' of github.com:lisambet/transcendence

9aca1a1

feat: update join-game route to accept sessionId as query param and m…

607d650

…odify AI invitation logic

fix: debug so that ai player actually moves the paddle

7c033df

feat: searching for a way to train a really strong model

bfbb489

fix: self._http.headers.update commented, train_strong_agent changed

bb76dc2

fix: compilation of dependencies problem

8f8ed74

Merge branch 'main' of github.com:lisambet/transcendence

1acb719

fix: package-lock deleted for merging

eceb1f4

Merge branch 'main' into lisambet

8f4035f

Merge pull request #2 from lisambet/lisambet

e5c5bb1

Lisambet

fix: kept these chages for later

02ab80f

fix: clean up

204e490

fix: for compilation

ceb4b63

Merge branch 'main' into prod

4dc680b

Merge pull request #3 from lisambet/prod

b97e920

fix: kept these chages for later

fix: clean up

6f63989

Merge branch 'main' of github.com:lisambet/transcendence

5481310

Merge pull request #62 from lisambet/main

7dd3ec3

ai-opponent integration

lisambet requested review from Ilia1177, codastream, jmtth and rom98759 as code owners February 3, 2026 14:23

lisambet linked an issue Feb 3, 2026 that may be closed by this pull request

AI opponent integration #61

Open

13 tasks

lisambet changed the title ~~61 ai opponent integration~~ AI: opponent first integration Feb 3, 2026

Copilot AI mentioned this pull request Feb 3, 2026

Randomize initial serve direction in Pong game #64

Closed

Merge remote-tracking branch 'origin/main' into 61-ai-opponent-integr…

5f20095

…ation

codastream requested a review from Copilot February 3, 2026 16:44

Copilot started reviewing on behalf of codastream February 3, 2026 16:44 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

lisambet requested a review from Copilot February 4, 2026 13:11

Copilot started reviewing on behalf of lisambet February 4, 2026 13:11 View session

fix: health controller initializes name

029c8ad

Copilot AI reviewed Feb 4, 2026

View reviewed changes

lisambet and others added 3 commits February 4, 2026 14:39

fix: readme update

5d7b7c5

fix: prettier update

95a1adc

feat: add AI opponent model and evaluation files

9258cb3

codastream reviewed Feb 6, 2026

View reviewed changes

Ilia1177 requested changes Feb 6, 2026

View reviewed changes

codastream requested changes Feb 7, 2026

View reviewed changes

lisambet and others added 9 commits February 8, 2026 10:29

chore: remove some AI model checkpoints

37b2127

fix: dependencies for pong-ai

961cd53

Makefile docs/pong-ai.md srcs/dev-docker-compose.yml srcs/docker-compose.yml srcs/pong-ai/Dockerfile srcs/pong-ai/ai_player.py srcs/pong-ai/requirements.txt

feat: implemented unit tests for AIService and deleted dead code from…

11e3ca2

… pong_server

Merge branch 'main' into 61-ai-opponent-integration

4fc0ab3

Update srcs/gateway/src/controllers/health.controller.ts

6e13ad6

Co-authored-by: Francois <multicompte+github@outlook.fr>

Update srcs/game/src/core/game.engine.ts

881536e

Co-authored-by: Francois <multicompte+github@outlook.fr>

Update srcs/gateway/src/controllers/health.controller.ts

34b8ae6

Co-authored-by: Francois <multicompte+github@outlook.fr>

Update srcs/gateway/src/controllers/pong-ai.controller.ts

a6d5ef2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: integrate environment variables for AI service and enhance conn…

8b2173e

…ection handling in AIPlayer

codastream reviewed Feb 12, 2026

View reviewed changes

chore: update AI model path to best_model and remove deprecated check…

440af56

…points

		except Exception as e:
		raise HTTPException(status_code=500, detail=str(e))

		@@ -1,2 +1,2 @@
		import { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
		import { logger } from '../utils/logger.js';


	export async function healthAllHandler(req: FastifyRequest) {

		@@ -0,0 +1,41 @@
		import { FastifyInstance } from 'fastify';
		import { proxyRequest, webSocketProxyRequest } from '../utils/proxy.js';

	import { proxyRequest, webSocketProxyRequest } from '../utils/proxy.js';
	import { proxyRequest } from '../utils/proxy.js';

Conversation

lisambet commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lisambet commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codastream left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codastream left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lisambet commented Feb 3, 2026 •

edited

Loading