Skip to content

NABU-1538: clarify Spend vs Supplier Analysis minimum-spend filter#1835

Merged
TedBaileyCodat merged 6 commits into
mainfrom
NABU-1538-spend-analysis-minimum-spend-glossary
May 27, 2026
Merged

NABU-1538: clarify Spend vs Supplier Analysis minimum-spend filter#1835
TedBaileyCodat merged 6 commits into
mainfrom
NABU-1538-spend-analysis-minimum-spend-glossary

Conversation

@TedBaileyCodat
Copy link
Copy Markdown
Collaborator

@TedBaileyCodat TedBaileyCodat commented May 26, 2026

Summary

  • Customer-tab row clarifies that the Excludes suppliers with annual spend below threshold only filters the Supplier Analysis tab; Spend Analysis totals are calculated across all suppliers.
  • New :::note under the Spend Analysis tab section makes the divergence explicit: when the threshold is non-zero, Spend Analysis Overall totals will exceed the sum of Supplier Analysis supplier rows.

Pairs with the glossary update in reports-generation (NABU-1538-spend-analysis-minimum-spend-glossary).

Context

NABU-1538 — Amex (Peacocks) flagged a totals mismatch between the two sheets. Root cause: AnnualSupplierMinimumSpend is applied to Supplier Analysis only. Decision was to document the behaviour rather than change the report.

Test plan

  • npm run format:mdx:check against docs/spend-insights/reports/spend-analysis.md (Prettier was not run locally — no node_modules)
  • npm run build to confirm Docusaurus renders the new :::note admonition
  • Visual review of the rendered Customer-tab table row width

The Annual Supplier Minimum Spend threshold only filters the Supplier
Analysis tab — Spend Analysis tab totals are calculated across all
suppliers. Add a note and tighten the Customer-tab row to set the right
expectation when the threshold is non-zero.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codat-docs Ready Ready Preview, Comment May 27, 2026 6:58pm

Request Review

Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Shorten the *Excludes suppliers with annual spend below* row so prettier's
markdown table check stays green; the detailed Spend vs Supplier divergence
already lives in the :::note added under the Spend Analysis tab.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
Comment thread docs/spend-insights/reports/spend-analysis.md Outdated
- Rephrase the Insight cell to active voice ("The Supplier Analysis tab
  omits suppliers below this threshold")
- Rewrite the :::note to drop passive voice, the "is not"/"non-zero"
  constructions, the spaced em-dash, and "will" — keeping the same
  meaning

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Comment thread docs/spend-insights/reports/spend-analysis.md
Comment thread docs/spend-insights/reports/spend-analysis.md
@TedBaileyCodat TedBaileyCodat marked this pull request as ready for review May 27, 2026 09:29
@TedBaileyCodat TedBaileyCodat enabled auto-merge May 27, 2026 12:44
@github-actions
Copy link
Copy Markdown

Link check results for preview deployment (https://codat-docs-git-NABU-1538-spend-analysis-minimum-spend-glossary-codat.vercel.app):

[]

@TedBaileyCodat TedBaileyCodat merged commit b38a0e0 into main May 27, 2026
7 of 9 checks passed
@TedBaileyCodat TedBaileyCodat deleted the NABU-1538-spend-analysis-minimum-spend-glossary branch May 27, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants