Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new job_run_id field to the action job “create” request so clients can optionally include a GitHub Actions run identifier when pushing results to the API.
Changes:
- Add
job_run_idtoCreateCargoWallActionJobRequestin the protobuf schema. - Regenerate Go protobuf bindings to include
JobRunIdaccessors/fields. - Add a new
--job-run-idCLI flag and include it in the API request when provided.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
proto/v1/cargo_wall_action.proto |
Adds job_run_id to the request message (currently implemented by renumbering fields). |
pb/cargowall/v1/cargo_wall_action.pb.go |
Regenerated Go bindings reflecting the new request field. |
cmd/summary.go |
Adds CLI flag and sets JobRunId on the outgoing request when non-zero. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew DeVenny <matt@codecargo.com>
de42522 to
b121bf5
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
job_run_idto theCreateCargoWallActionJobRequestWe'll start with it as optional and then make it required once its been fully adopted
Related to code-cargo/cargowall-action#39