[rebrand] Modernize puzzle-complete feedback dialog paint#74085
Open
alex-m-brown wants to merge 6 commits into
Open
[rebrand] Modernize puzzle-complete feedback dialog paint#74085alex-m-brown wants to merge 6 commits into
alex-m-brown wants to merge 6 commits into
Conversation
Repaints the shared puzzle-complete feedback dialog (opened by FeedbackUtils.displayFeedback after Run in any Blockly/Droplet lab) with semantic design-system tokens. No LegacyDialog shell swap - the qtip-style paint approach: CSS tokens on the surface, minimal JS. Scoped under .dash_modal so nothing leaks to react-bootstrap modals in PD/account/teacher-tools surfaces. - .x-close: dropped the 61x59 PNG close-button mixin; renders a small fa-xmark in --text-neutral-quaternary, transparent bg (matches the qtip close X). One-line JS in LegacyDialog.js adds <i class="fa-solid fa-xmark"> inside the close button. - .congrats / .lines-of-code-message: MUI-mirroring typography via --font-family-main, --font-size-body-lg, --font-weight-semi-bold / -regular; --text-neutral-primary color. Targets specific class names so the Show Code panel's own p/pre inside .generated-code-container is untouched. - .show-code > summary: semantic tokens, DS type. !important is needed because CodeWritten sets inline styles on the summary element. - #feedbackButtons: right-aligned flex row (via the inner DialogButtons wrapper), 12px gap. Continue = --background-brand-purple-primary filled, Replay = outlined via --borders-neutral-strong. !important needed to beat LegacyButton's Radium inline styles. - #puzzleRatingButtons: display: none, per product ask to drop the "Did you like this puzzle?" row. Followups: LegacyButton -> MUI Button (retire the Radium !important dance); K1 arrow Continue button retains its arrow shape here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Downstream tests depend on #puzzleRatingButtons being in the DOM, so keep the row and paint it to match the rest of the modernized dialog: - Separator: --borders-neutral-primary - Label: Geist, 16px, --text-neutral-tertiary - Heart/frown icons: --text-neutral-quaternary at rest, --text-neutral-primary on hover/enabled Overrides apps/style/common.scss:652 via .dash_modal scope + !important on the id-specific fills. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alex-m-brown
marked this pull request as ready for review
July 24, 2026 18:24
molly-moen
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repaints the shared puzzle-complete feedback dialog (opened by
FeedbackUtils.displayFeedbackafter Run in any Blockly/Droplet lab) with semantic design-system tokens. No LegacyDialog shell swap - CSS-only paint plus small source-level color swaps inLegacyButton.jsxScope: puzzle-complete dialog specifically. Everything else scoped under
.dash_modalso it doesn't touch react-bootstrap modals in PD/account/teacher-tools surfaces.What changed
fa-solid fa-xmarkin--text-neutral-quaternary, transparent bg. Same treatment as the qtip PR. One line inLegacyDialog.jsadds<i class="fa-solid fa-xmark">inside the button..congratsand.lines-of-code-messageswap legacy$neutral_dark+main-font-semi-boldfor--font-family-main+--font-size-body-lg+--font-weight-semi-bold/-regular+--text-neutral-primary. Targets specific classes so the Show Code panel's own p/pre inside.generated-code-containeris untouched..show-code > summarygets semantic tokens + DS type.!importantneeded because CodeWritten writes inline styles on the summary.#feedbackButtonsis a right-aligned flex row (24px gap,align-items: centerso K1 Replay sits centered against the tall Continue arrow). The button colors themselves are set at source inLegacyButton.jsx(see below), so no!importantcolor overrides in the SCSS.BUTTON_TYPES.legacyPrimary(LegacyButton.jsx):color.orange->var(--background-brand-purple-primary)for bg + border. Radium's inline style passes the CSS var through; the browser resolves it. This is the only reason the K1 Continue arrow head recolors automatically - the head readsconfig.style.backgroundColorat render time. Blast radius:legacyPrimaryis only used by DialogButtons for the Continue button, and Continue only renders when the caller passesnextLevel={true}- which is onlydisplayFeedbackin puzzle-complete. No other button in the app changes color.BUTTON_TYPES.cancel(LegacyButton.jsx):neutral_white/neutral_dark/neutral_dark20->--background-neutral-primary/--borders-neutral-strong/--text-neutral-primary/--background-neutral-tertiary(hover). Blast radius: ~15 dialog Cancel/Replay buttons across weblab/javalab/applab/levelbuilder/data-browser plus feedback's Replay. Visual delta is subtle in light theme (#292F36->#9ea5adborder tint); semantically correct.--borders-neutral-primaryseparator, Geist 16px--text-neutral-tertiarylabel, heart/frown icons in--text-neutral-quaternaryat rest /--text-neutral-primarywhen hovered or enabled.Testing story
Before screenshots



After screenshot




Then manually test:
.dash_modal).html[dir=rtl]): X should flip to left, layout should mirror, K1 arrow should still point in the correct direction.Make sure you ask @:
--background-brand-purple-primary; Replay is--background-neutral-primarywith--borders-neutral-strongborder. Confirm this is the right pairing for the puzzle-complete surface.