feat: Add Repository pattern for Vault entity (#633)#631
Open
raphael-01-visual wants to merge 1 commit into
Open
feat: Add Repository pattern for Vault entity (#633)#631raphael-01-visual wants to merge 1 commit into
raphael-01-visual wants to merge 1 commit into
Conversation
|
@raphael-01-visual is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@raphael-01-visual Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@vic-Gray , pls review PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #633
Related #362
What:
Extracts all direct TypeORM data access calls from
VaultsServiceinto a newly created, dedicatedVaultRepository.Why:
Previously,
VaultsServicewas tightly coupled with TypeORM's genericRepository<Vault>. By separating the data access layer from the business logic layer, this refactoring significantly improves the testability, maintainability, and modularity of the Vaults domain.Changes Made
VaultRepository: Addedbackend/src/vaults/vault.repository.tsas an abstraction layer with explicit data-access methods (findAll,findById,save, andfindLeaderboard).VaultsService: Replaced all TypeORMRepository<Vault>usages with calls to the newVaultRepository.VaultsModule: Injected and exported theVaultRepositoryprovider where necessary.VaultsServiceunit tests (vaults.service.spec.ts) to successfully mock and test against the new custom repository methods, ensuring 100% functionality retention.Type of change
Checklist:
Closes #362
Closes #361
Closes #359
Closes #360