Skip to content

fix(cash): race between give transactor dispose and start on quick bg/fg #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
May 11, 2026
Merged

fix(cash): race between give transactor dispose and start on quick bg/fg #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .../opencode/src/main/kotlin/com/getcode/opencode/internal/transactors/GiveBillTransactor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import com.getcode.utils.TraceType
import com.getcode.utils.trace
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.cancel
import kotlinx.coroutines.isActive
import kotlin.time.Duration

/**
Expand Down Expand Up @@ -112,6 +113,10 @@ internal class GiveBillTransactor(
* @return the confirmed [TransactionMetadata.SendPublicPayment] on success.
*/
suspend fun start(): Result<TransactionMetadata.SendPublicPayment> {
if (!scope.isActive) {
return logAndFail(GiveTransactorError.Other(message = "Transactor was disposed"))
}

val ownerKey = owner
?: return logAndFail(GiveTransactorError.Other(message = "No owner key. Did you call with() first?"))
val desiredToken = token
Expand Down Expand Up @@ -212,13 +217,13 @@ internal class GiveBillTransactor(

/** Cancels the coroutine scope and clears all held state. */
fun dispose() {
scope.cancel()
owner = null
presentationData = BillPresentationData(emptyList(), emptyList())
rendezvousKey = null
receivingAccount = null
token = null
providedVerifiedState = null
scope.cancel()
}

sealed class GiveTransactorError(
Expand Down
1 change: 0 additions & 1 deletion services/opencode/src/main/kotlin/com/getcode/opencode/managers/BillTransactionManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import com.getcode.opencode.controllers.AccountController
import com.getcode.opencode.controllers.MessagingController
import com.getcode.opencode.controllers.TransactionController
import com.getcode.opencode.exchange.VerifiedFiatCalculator
import com.getcode.opencode.internal.domain.mapping.MintMapper
import com.getcode.opencode.internal.manager.VerifiedState
import com.getcode.opencode.internal.transactors.AccountClusterFactory
import com.getcode.opencode.internal.transactors.BillPresentationData
Expand Down
Loading