feat(onramp): notify server of swap before Google Pay is presented#702
Merged
Conversation
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Move the buy() call from after payment success to before Google Pay is shown, so the server can handle order polling and settlement. Remove the Processing intermediate state and make SwapRequest.fundingIntentId lazy to avoid eager evaluation for CoinbaseOnramp sources. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the buy() call from after payment success to before Google Pay is
shown, so the server can handle order polling and settlement. Remove the
Processing intermediate state and make SwapRequest.fundingIntentId lazy
to avoid eager evaluation for CoinbaseOnramp sources.