Skip to content

password length minimum plus tests for it #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timberwolf1939 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

password length minimum plus tests for it #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions beer-buddy-web/src/main/java/com/beerbuddy/web/controller/rest/LoginController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ public ResponseEntity<?> authenticate(@RequestBody NewUserRequest request) {
//clear context to be safe
SecurityContextHolder.clearContext();

if (request.getPassword().trim().length() < 8)//checks to make sure password is at least 8 characters long
{
log.error("Too Short Password");
Map<String, String> error = ImmutableMap.
of("error", "The password is too short",
"message", "The password must be at least 8 characters long.");
return new ResponseEntity<>(error, HttpStatus.UNAUTHORIZED);
}

Authentication auth = new UsernamePasswordAuthenticationToken(request.getUsername(), request.getPassword());
try {
auth = beerBuddyAuthenticationManager.authenticate(auth);
Expand Down
8 changes: 8 additions & 0 deletions beer-buddy-web/src/main/java/com/beerbuddy/web/controller/rest/UserController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ public class UserController implements BeerMapper {
@RequestMapping(method=RequestMethod.POST)
public ResponseEntity<?> create(@RequestBody NewUserRequest request) {
try {
if (request.getPassword().trim().length() < 8)//checks to make sure password is at least 8 characters long
{
Map<String, String> error = ImmutableMap.
of("error", "The password is too short",
"message", "The password must be at least 8 characters long.");
return new ResponseEntity<>(error, HttpStatus.UNAUTHORIZED);
}

User user = userService.createUser(request.getUsername(), request.getPassword());
UserProfile profile = new UserProfile();
profile.setEmail(request.getEmail());
Expand Down