Skip to content

🔧 refactor ci pipeline diagnostics for improved clarity and efficiency#143

Merged
gimlichael merged 2 commits intomainfrom
v10.2.0/gha-xunit-permissions
Feb 10, 2026
Merged

🔧 refactor ci pipeline diagnostics for improved clarity and efficiency#143
gimlichael merged 2 commits intomainfrom
v10.2.0/gha-xunit-permissions

Conversation

@gimlichael
Copy link
Member

@gimlichael gimlichael commented Feb 10, 2026

This pull request simplifies and generalizes the CI pipeline diagnostics step in .github/workflows/ci-pipeline.yml. It removes some .NET-specific and configuration-specific logic, broadens the search for executables, and streamlines the output for easier debugging of permission and execution issues.

Diagnostics and search improvements:

  • Generalized the brute-force chmod and file search to include all files in any bin or obj directories, not just those under a specific configuration or target framework.
  • Reduced the number of candidate executables and test host files displayed for easier review (e.g., top 100/50/20 instead of 200/50), and added error suppression for cleaner logs.

Output and debug information changes:

  • Removed detailed .NET, git, and configuration/environment output, focusing the diagnostics step solely on file permissions and executability issues.
  • Streamlined the deep diagnostics for executables: now only shows essential file info, ELF interpreter and dependencies (limited output), and checks for CRLF in shebangs.
  • Updated and clarified section headers for each diagnostics step for improved readability.

Summary by CodeRabbit

  • Chores
    • Improved Linux CI test environment: permission fixes for test app host now align with matrix-driven configurations and use broader file targeting so more build artifacts are covered; updated diagnostic output for clearer CI troubleshooting.

@gimlichael gimlichael self-assigned this Feb 10, 2026
Copilot AI review requested due to automatic review settings February 10, 2026 18:29
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

CI workflow adjustments: the Linux integration test apphost permission diagnostic now echoes matrix.configuration (not inputs.configuration) and replaces configuration-specific bin/obj paths with wildcard glob patterns to target all matrix-driven build outputs.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/ci-pipeline.yml
Echo now reports matrix.configuration instead of inputs.configuration. Bin/obj permission globs changed from configuration-specific paths to wildcards (e.g., */bin/*/net*/*, */obj/*/net*/*), broadening targeted files for chmod operations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • v10.1.1/ci fix #138: Makes similar changes to CI workflow Linux apphost permission handling by switching bin/obj discovery to wildcard globs and aligning with matrix-driven configurations.

Poem

🐰 I hopped through CI with curious cheer,

Swapped one small echo and widened the sphere,
Wildcard footprints now trace every bin,
Permissions aligned — let the tests begin! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title uses an emoji and vague language ('refactor', 'diagnostics', 'improved clarity and efficiency') that don't clearly communicate the specific changes made to CI pipeline permissions and file handling. Consider using a more specific title like 'Fix Linux test apphost permissions by generalizing bin/obj directory checks' that clearly describes the main change without emojis.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v10.2.0/gha-xunit-permissions

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the CI pipeline diagnostics in .github/workflows/ci-pipeline.yml to make Linux permission/executability troubleshooting more general and less noisy by focusing on bin/ + obj/ file permissions and targeted executable diagnostics.

Changes:

  • Generalizes the brute-force chmod and file discovery from configuration/framework-specific bin/obj paths to all bin/ and obj/ directories.
  • Streamlines diagnostics output by truncating lists, suppressing non-essential errors, and reducing deep-dive output to key ELF/shebang signals.
  • Removes broader environment/.NET/git context output to keep the step focused on executability issues.

@gimlichael gimlichael merged commit f95659e into main Feb 10, 2026
17 of 301 checks passed
@gimlichael gimlichael deleted the v10.2.0/gha-xunit-permissions branch February 10, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant