Conversation
📝 WalkthroughWalkthroughThis pull request performs routine maintenance across the project infrastructure and dependencies. It updates the nginx base image from 1.29.4 to 1.29.5 in the DocFX Dockerfile, adds multi-architecture support (X64 and ARM64) to the CI/CD pipeline with separate test stages, bumps six package versions in the central package manifest, updates the test environment Docker image, and documents a 0.5.2 service release. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~13 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Service update for v0.5.2 that upgrades centrally-managed package dependencies and refactors the GitHub Actions CI pipeline to better support multi-architecture (ARM64) builds/tests, with accompanying documentation and container image updates.
Changes:
- Upgraded several NuGet package versions via
Directory.Packages.propsand documented the release inCHANGELOG.mdand per-package release notes. - Refactored CI workflow to add ARM64 to build and split testing into Linux/Windows jobs, updating downstream job dependencies accordingly.
- Updated supporting infrastructure references (CI badge, test runner image tag, DocFX/nginx base image).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
testenvironments.json |
Updates the Ubuntu docker test runner image/tag used for local/CI test environments. |
README.md |
Updates the CI badge to point at the renamed workflow file. |
Directory.Packages.props |
Bumps centrally-managed package versions for the service release. |
CHANGELOG.md |
Adds the 0.5.2 changelog entry. |
.nuget/Codebelt.SharedKernel/PackageReleaseNotes.txt |
Adds 0.5.2 release notes for the SharedKernel package. |
.github/workflows/ci-pipeline.yml |
Adds ARM64 support and splits tests into test_linux / test_windows; updates job dependencies. |
.docfx/Dockerfile.docfx |
Updates the nginx base image version used for DocFX output hosting. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Directory.Packages.props`:
- Around line 13-14: The PackageVersion entries for coverlet.collector and
coverlet.msbuild were bumped to 8.0.0 but Coverlet 8 requires .NET 8 and
specific SDK/test SDK versions; verify your CI/build agents and developer
machines are running .NET SDK 8.0.112+ and update Microsoft.NET.Test.Sdk to
17.12.0+ if needed, and confirm any projects depending on coverlet.core can
target net8.0 (or add a compatible coverlet.core) — if you cannot guarantee
those upgrades, revert the PackageVersion changes for
coverlet.collector/coverlet.msbuild to the previous compatible version instead
of 8.0.0.
🧹 Nitpick comments (1)
.docfx/Dockerfile.docfx (1)
13-17: Consider adding a non-rootUSERdirective in the final stage.Trivy flags that this Dockerfile runs as root (DS-0002). For an nginx container serving static docfx content, you could switch to the unprivileged nginx user in the final stage to reduce attack surface.
Suggested change
FROM nginx:${NGINX_VERSION} AS final WORKDIR /usr/share/nginx/html COPY --from=build /build/docfx/wwwroot /usr/share/nginx/html +USER nginx ENTRYPOINT ["nginx", "-g", "daemon off;"]Note: Verify that the
nginxuser exists in the alpine-based image and that file permissions allow it to function correctly.
| <PackageVersion Include="coverlet.collector" Version="8.0.0" /> | ||
| <PackageVersion Include="coverlet.msbuild" Version="8.0.0" /> |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
coverlet 8.0.0 breaking changes from version 6.0
💡 Result:
Coverlet v8.0.0 introduces (relative to v6.0.x) these practical breaking changes:
- Minimum .NET raised to .NET 8 (LTS): v8.0.0 “upgraded minimum required .NET SDK and runtime to .NET 8.0 LTS” (explicitly called out as a Breaking Change). If your build agents/dev machines are on .NET 6/7, you must upgrade to .NET 8.0+. [1]
- If you consume Coverlet as components/tools, they now expect .NET 8-era tooling (per project docs):
coverlet.collector: requires .NET 8 SDK 8.0.112+ and Microsoft.NET.Test.Sdk 17.12.0+. [2]coverlet.console(.NET global tool): requires .NET 8.0 or above. [2]
coverlet.coremoved tonet8.0and droppedNewtonsoft.Json(can break you if you referencecoverlet.coredirectly from a project targeting older TFMs, or relied on the transitive Newtonsoft dependency). [1]
Note: the repo tags/releases jump from 6.0.4 to 8.0.0 (no 7.x release line to account for). [1]
Verify .NET 8 SDK compatibility before upgrading coverlet to 8.0.0.
Coverlet 8.0.0 raises the minimum required .NET to 8.0 LTS and drops support for .NET 6/7. Additionally:
coverlet.collectorrequires .NET 8 SDK 8.0.112+ and Microsoft.NET.Test.Sdk 17.12.0+coverlet.corenow targets only net8.0 and no longer includes Newtonsoft.Json (transitive dependency removed)
Confirm your build agents and development environment run .NET 8.0+ before proceeding.
🤖 Prompt for AI Agents
In `@Directory.Packages.props` around lines 13 - 14, The PackageVersion entries
for coverlet.collector and coverlet.msbuild were bumped to 8.0.0 but Coverlet 8
requires .NET 8 and specific SDK/test SDK versions; verify your CI/build agents
and developer machines are running .NET SDK 8.0.112+ and update
Microsoft.NET.Test.Sdk to 17.12.0+ if needed, and confirm any projects depending
on coverlet.core can target net8.0 (or add a compatible coverlet.core) — if you
cannot guarantee those upgrades, revert the PackageVersion changes for
coverlet.collector/coverlet.msbuild to the previous compatible version instead
of 8.0.0.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 11 11
Lines 200 200
Branches 8 8
=======================================
Hits 177 177
Misses 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
1 participant
This pull request introduces a service update focused on upgrading package dependencies and improving CI/CD pipeline support for multiple architectures. The changes ensure compatibility with the latest dependency versions and add ARM64 support across build and test jobs, as well as update related documentation and Docker images.
Dependency upgrades:
Directory.Packages.props, includingCuemon.Extensions.IO,Codebelt.Extensions.Xunit.App,Savvyio.Extensions.Newtonsoft.Json,Savvyio.Extensions.Text.Json, andcoverletpackages, to their latest compatible releases..nuget/Codebelt.SharedKernel/PackageReleaseNotes.txt, highlighting upgraded dependencies across all supported target frameworks.CHANGELOG.mddescribing the service update for package dependencies.CI/CD pipeline enhancements:
.github/workflows/ci-pipeline.ymlto add ARM64 support for build and test jobs, split tests intotest_linuxandtest_windows, and updated artifact and job dependencies accordingly. [1] [2] [3]README.mdto reference the new pipeline file (ci-pipeline.yml).Environment and Docker image updates:
testenvironments.jsonto a newer version..docfx/Dockerfile.docfxfrom 1.29.4-alpine to 1.29.5-alpine.Summary by CodeRabbit
New Features
Chores