TKW: mobile family tree polish — chart-only view + 800% zoom#6
Merged
Conversation
- `useIsMobile` hook keyed to `bp.$sm` (`max-width: 639.98px`) - `FamilyTreeViewSwitcher` skips toggle + list when mobile - chart shows even with `?tree=list` in the URL on mobile
… scale - `MAX_SCALE` 8 → 16; preset list gains `800%` - `MOBILE_INITIAL_SCALE = 4` (the new `200%`) applied once post-mount on mobile - `reset()` honours the live `isMobile` value - `initialCenteredTransform` takes an explicit `scale` parameter
✅ Deploy Preview for theknownworld ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…traits - populate `content/characters/arlan-of-pennytree.md` from AWOIAF (born ~150 AC, died 209 AC, `Ser` title, 3-paragraph body) - populate `content/characters/hodor.md` from AWOIAF (alias `Walder`, 3-paragraph body; no canon dates) - swap `melisandre` and `missandei` portraits from PNG to JPG - add portraits for `arlan-of-pennytree`, `leo-tyrell`, `lyonel-baratheon`, `robyn-rysling`, `tanselle` - stash rejected `leo` alternate at `public/backups/leo.jpg`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
≤ bp.$sm(639.98px),FamilyTreeViewSwitcherrenders only the chart — no toggle, no list — even when?tree=listis in the URL.FamilyTreeChartmax zoom raised from 8 → 16; new800%preset alongside the existing 25 / 50 / 100 / 200 / 400%.MOBILE_INITIAL_SCALE = 4(the "200%") once post-mount, so iPhone users see a legible initial view instead of the desktop default fit.reset()honours the liveisMobilevalue.lib/useIsMobile.ts(keyed tobp.$sm) drives both components.Test plan
bun run test— full suite (351 tests, 34 files)bun run typecheck+bun run lintclean> 639.98px): list ↔ chart toggle still works; URL?tree=charthonouredResetreturns to 4800%preset zooms inner<g>toscale(16); pinch / wheel cap at 16