Implement S3-compatible storage client abstraction (#224)#289
Open
gabrieltemtsen wants to merge 1 commit into
Open
Implement S3-compatible storage client abstraction (#224)#289gabrieltemtsen wants to merge 1 commit into
gabrieltemtsen wants to merge 1 commit into
Conversation
|
@gabrieltemtsen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Storage Client Wrapper: Implemented the provider-agnostic ObjectStore interface and S3ObjectStore class in
objectStore.ts
using @aws-sdk/client-s3 and @aws-sdk/s3-request-presigner.
Config Updates: Modified
config.ts
to define optional S3-specific configuration variables in EnvSchema.
Router Integration: Updated
files.ts
to utilize the new objectStore singleton instance.
Tests: Created unit tests in
objectStore.test.ts
covering configuration settings, presigned URL generation, head responses, metadata retrieval, deletions, and error-handling conditions.
Verification: Ran pnpm --filter backend test verifying that all 166 tests passed successfully.
closes #224
Type of change
Checklist