Open
Conversation
codecat
requested changes
Jun 11, 2023
Comment on lines
+153
to
+157
| return null; | ||
| } | ||
| $row = $res->fetch_assoc(); | ||
| if(!$row) { | ||
| return false; | ||
| return null; |
Owner
There was a problem hiding this comment.
Returning null instead of false is a really big breaking change! I'd prefer if we can still keep returning false here, to make sure existing checks don't break (for example, === false and !== false)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if there's no results it throws a conniption because false is not a model
switched returning false to returning null because that's easier to do as a return type, which should also work fine with all the openplanet cases i've seen this be relevant to (for example
PluginAdminController::actionNewVersion())