Skip to content

Fix bug in generate href #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelina-momin merged 1 commit into from
Jun 19, 2024
Merged

Fix bug in generate href #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions R/utils_render_reigster_html.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,21 +115,37 @@ generate_html_postfix_hrefs <- function(filter, register_table_name) {
generate_href <- function(filter, register_table_name, href_type) {
# Determine base path based on the resource type
href_details <- switch(href_type,
"csv_source" = list(base_url = "https://raw.githubusercontent.com/codecheckers/register/master/docs/", ext = ".csv"),
"searchable_csv" = list(base_url ="https://github.com/codecheckers/register/blob/master/docs/", ext = ".csv"),
"csv_source" = list(base_url = "https://raw.githubusercontent.com/codecheckers/register/master/", ext = ".csv"),
"searchable_csv" = list(base_url ="https://github.com/codecheckers/register/blob/master/", ext = ".csv"),
"json" = list(base_url = "https://codecheck.org.uk/register/", ext = ".json"),
"md" = list(base_url = "https://codecheck.org.uk/register/", ext = ".md")
)

base_url <- href_details$base_url
# For the original register
if (filter == "none") {
return(paste0(href_details$base_url, "register", href_details$ext))
} else if (filter == "venues") {
return(paste0(base_url, "register", href_details$ext))
}

# Determining if we need to include "/docs" in the href. This is needed for the correct path
# to the csv files in the github repo
include_docs_in_href <- href_type %in% c("csv_source", "searchable_csv")
if (include_docs_in_href){
base_url <- paste0(base_url, "docs/")
}

# Setting href for venue filter
if (filter == "venues") {
venue_category <- determine_venue_category(register_table_name)
venue_name <- trimws(gsub("[()]", "", gsub(venue_category, "", register_table_name)))
venue_name <- gsub(" ", "_", venue_name)
return(paste0(href_details$base_url, filter, "/", venue_category, "/", venue_name, "/register", href_details$ext))
} else {
return(paste0(href_details$base_url, filter, "/", register_table_name, "/register", href_details$ext))

return(paste0(base_url, filter, "/", venue_category, "/", venue_name, "/register", href_details$ext))
}

# For all other filters
else {
return(paste0(base_url, filter, "/", register_table_name, "/register", href_details$ext))
}
}

Expand Down