Add tests for handling missing and non-executable test.sh in build process.#5
Merged
Merged
Conversation
| flunk "Expected build to fail with missing test.sh" | ||
| rescue | ||
| # Expected to fail | ||
| end |
There was a problem hiding this comment.
Bug: Bare rescue catches flunk exception masking test failures
The bare rescue catches all StandardError subclasses, including Minitest::Assertion raised by flunk. If run_script! unexpectedly succeeds, flunk is called but immediately caught by the rescue block, causing the test to continue rather than fail with the intended message. The test would eventually fail at subsequent assertions but with a confusing error message, making debugging harder. The rescue block needs to specify the expected exception type (like RuntimeError) to avoid swallowing the flunk assertion.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Validate presence/executability of tester test.sh, add tests for failures, broaden Dockerfile distro handling, and bump language fixtures.
tester_dir/test.shexists and is executable before building; return internal errors if missing/invalid.test.shwith assertions on error logs.tester_dirintoBuildImageCommandRunner#run.debian,noble,trixie; clarify error message for unknownFROMlines.ruby-3.4,rust-1.91,go-1.25; adjustCodeFixturesand copy paths accordingly.Written by Cursor Bugbot for commit 1f3adae. This will update automatically on new commits. Configure here.