Improve line continuation detection inside string literals#24
Closed
d-alonso wants to merge 0 commit into
Closed
Conversation
d-alonso
requested review from
a team,
alvrogd and
inaki-amatria
and removed request for
a team
d-alonso
force-pushed
the
feature/improveContinuationString
branch
2 times, most recently
from
b16f802 to
360f154
Compare
Author
|
I have now merged the PR upstream and turned this PR into a merge back downstream |
d-alonso
force-pushed
the
feature/improveContinuationString
branch
from
360f154 to
865555f
Compare
Author
|
This PR was merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the test is pretty self explanatory. The loop consuming the string literals was double-advancing when detecting an ampersand that was not really a line continuation.