fix: use hvc1 codec tag for HEVC output on macOS#123
Open
sjhddh wants to merge 1 commit intocodeforreal1:mainfrom
Open
fix: use hvc1 codec tag for HEVC output on macOS#123sjhddh wants to merge 1 commit intocodeforreal1:mainfrom
sjhddh wants to merge 1 commit intocodeforreal1:mainfrom
Conversation
ffmpeg writes the hev1 codec tag by default for HEVC streams, but Apple's AVFoundation (Finder, QuickLook, QuickTime, Photos) only recognizes hvc1. This causes compressed HEVC videos to have no thumbnails and fail QuickLook preview on macOS. Appends -tag:v:0 hvc1 when the output codec is HEVC and the container is MP4 or MOV. Zero-cost metadata-only change with no impact on quality, file size, or encoding speed. Fixes codeforreal1#122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hev1codec tag for HEVC, but Apple's AVFoundation only recognizeshvc1-tag:v:0 hvc1when output codec is HEVC and container is MP4/MOVChanges
src-tauri/src/core/ffmpeg.rsafter the video codec is sethev1andhvc1equallyTest plan
cargo checkpassesFixes #122