feat: add Query Builder likeAny helpers#10261
Open
memleakd wants to merge 1 commit into
Open
Conversation
- add likeAny() and orLikeAny() for grouped OR LIKE searches - reuse existing LIKE handling for binds, escaping, RawSql, and insensitive search - document usage and add builder/live coverage Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
michalsn
approved these changes
Jun 4, 2026
patel-vansh
approved these changes
Jun 6, 2026
paulbalandan
approved these changes
Jun 6, 2026
datamweb
reviewed
Jun 7, 2026
|
|
||
| if (! is_string($field) || trim($field) === '') { | ||
| throw new InvalidArgumentException(sprintf('%s() expects $fields to contain only non-empty strings or RawSql instances', $caller)); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| if (! preg_match('/^[A-Za-z0-9_\.]+$/', $field)) { | |
| throw new InvalidArgumentException(sprintf('Invalid field name "%s". Only alphanumeric characters, underscore, and dot are allowed.', $field)); | |
| } |
I suggested the strict field-name check because these values are used as SQL identifiers, not regular data values, so is_string() alone doesn’t really guarantee they’re safe.
Using a small allowlist here feels like a nice extra guardrail before the query is built.
What do you think?
Contributor
Author
There was a problem hiding this comment.
Thanks for taking a look.
I don't think we should add this validation here. It would make this method more restrictive than the rest of Query Builder, and identifier protection should stay in the existing escaping/compiler flow.
I agree with the safety concern though, so I think a docs note about not passing user input directly as field names would be a better fit.
datamweb
suggested changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes adding
likeAny()andorLikeAny()to Query Builder.The goal is to make a very common search pattern easier to write: search one value across a few columns, while keeping those
LIKEconditions grouped safely.Instead of writing the group manually, this produces the expected shape:
This keeps the existing
like()behavior unchanged. Passing an associative array tolike()still creates multipleLIKEclauses joined withAND;likeAny()is only for the "same value across any of these fields" case.Internally this reuses the existing LIKE handling, so binds, escaping, wildcard placement,
RawSql, and case-insensitive search behave the same way aslike().Tests cover grouped SQL generation, binds, invalid field lists,
RawSql, case-insensitive search, and live database behavior.Checklist: