[지근영] Sprint10#154
Open
codes-gy wants to merge 6 commits into
Open
Conversation
peterhyun1234
approved these changes
Mar 25, 2026
Collaborator
peterhyun1234
left a comment
peterhyun1234
left a comment
There was a problem hiding this comment.
@codes-gy님 안녕하세요
🚀 총평
이번 PR은 단순 요구사항 구현을 넘어
AWS 기반으로 실제 운영 가능한 서비스 구조를 잘 구성한 제출물입니다.
S3, RDS, EC2뿐 아니라 pm2와 nginx까지 적용한 점,
그리고 Notification + Socket까지 확장한 부분에서
배포뿐 아니라 서비스 관점까지 고민하신 점이 인상적이었습니다.
다만,
NODE_ENV불일치- 일부 코드 오류 및 중복
- IAM/Access Key 사용 방식
등은 실제 운영에서 중요한 부분이므로 꼭 보완해 주세요.
전체적으로 방향은 매우 좋고,
조금만 다듬으면 실무에서도 바로 쓸 수 있는 수준까지 올라갈 수 있습니다.
고생 많으셨습니다! 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게