[이창호]sprint11#167
Merged
Merged
Conversation
ac9831
approved these changes
Apr 1, 2026
Collaborator
ac9831
left a comment
ac9831
left a comment
There was a problem hiding this comment.
수고많으셨습니다!
시간이 더 있으시면 좋았겠지만 정해진 날짜가 있어서 중간에 올려달라고 요청했습니다.
괜찮으시다면 남은 목표도 완성 시키는 것을 추천드립니다!
| --health-retries 5 | ||
|
|
||
| env: | ||
| DATABASE_URL: postgresql://panda:panda1234@localhost:5432/panda_market_test |
Collaborator
There was a problem hiding this comment.
하드코딩 되어 있는 것중 민감한 정보는 따로 .env로 빼는것을 추천드립니다.
| @@ -0,0 +1,20 @@ | |||
| FROM node:20-alpine | |||
Collaborator
There was a problem hiding this comment.
추후 멀티 스테이지 적용을 해보시는 걸 추천드립니다.
싱글 스테이지와 차이점을 확인하고 왜 멀티 스테이지를 구성해야 하는지 아는 것이 중요합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게