fix(transformer): handle URLs with spaces in HtmlTransformer#147
Merged
fix(transformer): handle URLs with spaces in HtmlTransformer#147
Conversation
Add a fallback URL resolution mechanism when java.net.URI throws URISyntaxException (e.g., for URLs containing spaces or other characters not allowed by RFC 2396). The fallback manually constructs absolute URLs by handling protocol-relative, absolute-path, relative, and scheme-based URLs without relying on URI.resolve(). Also add tests covering relative, absolute-path, protocol-relative, and parent-traversal URLs that contain spaces. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HtmlTransformerwhenjava.net.URIthrowsURISyntaxExceptionfor URLs containing spaces or other RFC 2396-invalid charactersChanges Made
URISyntaxExceptioncatch block that manually constructs absolute URLs by handling protocol-relative (//), absolute-path (/), query/fragment (?/#), scheme-based, and relative path URLsTesting
%20) in various URL patternsBreaking Changes
URI.resolve()already fails, so existing behavior is unchanged for valid URLs.🤖 Generated with Claude Code